Repository navigation
Correct validate task name to visual-baseline - #794
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct #793. It told lanes to run
validate.ps1 -Task windows-spikes, but no such task exists:windows-spikesis a CI workflow job. The task that runs the palette-parity contract isvisual-baseline. Lane B2 caught the mistake.Changes
investigation/windows-parity-orchestration-plan.md: the per-PR gate now names-Task visual-baseline(VisualBaseline.Tests.ps1plusPaletteParity.Tests.ps1). It states thatwindows-spikesis a CI job, and that every exact-head workflow must be green before merge.Test plan
RED: Select-String Tools\windows\validate.ps1 ValidateSet on main 1e48374 -> no windows-spikes task exists; the plan named one
GREEN: validate.ps1 lines 1004-1015 -> the visual-baseline task runs VisualBaseline.Tests.ps1 and PaletteParity.Tests.ps1 with a nonzero-count guard; plan now names -Task visual-baseline
REGRESSION: git diff --check -> clean; git ls-files --eol -> CRLF preserved; bash Tools/ci/tests/classify-changes.test.sh -> 59 passed, 0 failed
Documentation-only change: no product code, so the Windows suites and macOS
make test/make checkwere not run.Checklist
git commit -s) per the DCOmake test)make check)