Skip to content

Make the native UIA test harness robust to cleanup locks and vcvars extension failures #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coneilen merged 1 commit into from
Oct 14, 2026
Merged

Make the native UIA test harness robust to cleanup locks and vcvars extension failures #805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions Tools/windows/Tests/AccessibilityProvider.Native.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,35 @@ try {
$env:TMP = $scratch
$installer = Join-Path ${env:ProgramFiles(x86)} "Microsoft Visual Studio\Installer"
if (Test-Path -LiteralPath $installer) { $env:PATH = "$installer;$savedPath" }
Push-Location $scratch
try {
$test = Join-Path $PSScriptRoot "AccessibilityProvider.Native.Tests.cpp"
$provider = Join-Path $repoRoot "graphcode-windows\src\AccessibilityProvider.cpp"
$command = 'call "' + $VcVars + '" >nul && cl /nologo /EHsc /std:c++17 ' +
'/Fe:uia-native.exe "' + $test + '" "' + $provider + '" ' +
'oleaut32.lib uiautomationcore.lib user32.lib && .\uia-native.exe'
& $env:ComSpec /d /s /c $command
if ($LASTEXITCODE -ne 0) { throw "Native accessibility provider tests failed: $LASTEXITCODE" }
} finally {
Pop-Location
}
$test = Join-Path $PSScriptRoot "AccessibilityProvider.Native.Tests.cpp"
$provider = Join-Path $repoRoot "graphcode-windows\src\AccessibilityProvider.cpp"
# Change directory inside cmd only: a Push-Location here becomes this process's
# working directory at the native call and then locks the scratch folder.
# vcvars can exit non-zero when an optional extension (for example the Linux
# ConnectionManager) is absent even though the MSVC environment is usable, so
# require a resolvable cl instead of trusting its exit code.
$command = 'cd /d "' + $scratch + '" && call "' + $VcVars + '" >nul 2>&1 & ' +
'where cl >nul 2>&1 && cl /nologo /EHsc /std:c++17 ' +
'/Fe:uia-native.exe "' + $test + '" "' + $provider + '" ' +
'oleaut32.lib uiautomationcore.lib user32.lib && .\uia-native.exe'
& $env:ComSpec /d /s /c $command
if ($LASTEXITCODE -ne 0) { throw "Native accessibility provider tests failed: $LASTEXITCODE" }
} finally {
$env:TEMP = $savedTemp
$env:TMP = $savedTmp
$env:PATH = $savedPath
Remove-Item -LiteralPath $scratch -Recurse -Force
# The just-built test executable and compiler outputs can stay locked briefly
# (for example by an antivirus scan) after the process exits. Cleanup must not
# turn a passing run into a failure, so retry and then only warn.
for ($attempt = 1; Test-Path -LiteralPath $scratch; $attempt++) {
try {
Remove-Item -LiteralPath $scratch -Recurse -Force -ErrorAction Stop
} catch {
if ($attempt -ge 10) {
Write-Warning "Native accessibility test scratch was not removed: $scratch ($($_.Exception.Message))"
break
}
Start-Sleep -Milliseconds 500
}
}
}
Loading