Repository navigation
Pair combined macOS references without promoting Windows parity - #832
Merged
Merged
Conversation
Pair the final gap-fill item and qualified-row registers to the ledger, preserve accepted omissions and evidence limits, and clarify exact-command execution authority. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc23853f-810d-4ef2-b5de-b397605090d7 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Distinguish the operator's three new-image reviews from the separate earlier eleven-image v2 independent sample without changing reference coverage or clearance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc23853f-810d-4ef2-b5de-b397605090d7 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pair the newly returned combined macOS gap-fill references to the Windows parity ledger without changing any Windows parity status. Record the fourteen user-accepted omissions as macOS reference: accepted unrecorded, preserving dated intake, failed attempts, accounting deviations and the original publication hold.
Refs #822, #826, #764, #768, #767, #774, #778.
Changes
investigation\ui-parity-matrix.md: all 65 exact item IDs/outcomes, all 30 qualified rows, metadata locators and actual SHA-256 hashes from the localC:\gc-ref\macos-groundtruth-2ccf303a-gapfill-combined-20261015copy. Final tables are only those undermacos-groundtruth-2ccf303a-completed-v12, source2ccf303a04f995184aae1d4b738a9eca0f71b79e.update-other-workspaces,select-folder,image-drop.edge-focusunder v6 andoverview-foldersunder v3 are resolved under v2 and excluded as current success proof. Historicalprior_metadata_digestsand qualified-row fields are not current seals/dispositions. V4/V8 failures and source-only V7 remain qualified; V3's twelve turns exceeded its initial two-turn ceiling, distinct from V11's one permitted response and zero executed tools.investigation\windows-parity-lane-kickoff.mdandinvestigation\windows-parity-orchestration-plan.md. Add the requested concise command-lease retrospective: self-added validators/gates are out of lease; reading checker output does not authorize execution. The rp1 ANSI gate/post-conversion parser failures are process deviations, not product defects; its permanent executor stop stands.Accepted base:
baa2f0c6b9388f11219dd97e7d4cfed2176bc17b(#830). Before any push, the coordinator explicitly authorized a mechanical rebase from4a30b79d259228cbce7d23b16a3a81a9f8ee9446onto that exact accepted merge. Read-only fetch/diff confirmed only seven disjoint offscreen files; the rebase completed without conflicts or stash. None of those seven files or J5's capture-core work is edited here.Test plan
RED: pwsh -NoProfile -File C:\gcs\combined-intake\Test-CombinedIntake.ps1 -Phase RED -> exit 1; 2260 checks, 158 failures, including Missing/duplicate combined item: card-main-running and missing combined hashes/qualified-row crosswalk.
GREEN: pwsh -NoProfile -File C:\gcs\combined-intake\Test-CombinedIntake.ps1 -Phase GREEN -> exit 0; 2452 checks, zero failures; 65 items, 30 qualified rows, 98 unchanged canonical rows.
REGRESSION: pwsh -NoProfile -File C:\gcs\combined-intake\Test-CombinedIntake.ps1 -Phase REGRESSION -> exit 0; 2452 checks, zero failures; metadata/text/hash/status/hold/accounting invariants retained after complete ledger diff review.
The single explicitly granted scratch checker stayed unchanged between those three phases. Counts are documentation/reference assertions, not product tests, runtime passes or independent visual review. It checks final source identities, collection hash entries/path confinement, referenced text/JSON hashes and metadata item/capture identity, exact 65 outcomes and fourteen accepted IDs, all thirty Partial rows, the pre-edit 98-row snapshot, preserved historical intake, correction/hold/privacy/accounting wording and the command-lease retrospective.
Local evidence is retained under
C:\gcs\combined-intakeand is not committed:Test-CombinedIntake.ps18B8C481D444F3B2737884EE1913F2440F484B18D609B757C3901DD8AF58FFAF9canonical-baseline.json13AD4A99EDC0ADAAE44B2609AF9733C13923D0A17FF4A26EA40549571132A4E1RED.log058559548B3C5C3EAB84074641CF6EFEC2737190EE3D0825D6CE012810D5F06CGREEN.log57F956EE96C9F453965BB37538F8C4427C2B2427208FC6D9DC577ACB50D1499CREGRESSION.logD3A067737850381E1D3E0D1C4F39C6558CFE5D44EB230A13E7C6E87C1ADDF657preflight-01-missing-reference.log13AE65D9071A155BDCA919C7DDD1CCD3F7C9D78D49475D47355627FA7BD6218DAn earlier checker preflight stopped on a missing inherited v2 locator under v6; its original failing output is retained separately, not substituted for the intended RED or erased. The locator-aware final checker was fixed before the three recorded phases. An earlier read-only metadata command was blocked before execution by antivirus and supplied no evidence; no bypass was attempted.
git --no-pager diff --check-> exit 0, no whitespace errors.pwsh -NoProfile -File Tools\tdd\Test-TddEvidence.ps1 -BodyPath C:\gcs\combined-intake\pr-body.md-> exit 0,TDD evidence: PASS.Not verified / limits: no image opens, decoding, crops, copies, upload or new privacy verdict; no new screenshots, visual reviewer, product implementation, native/desktop/backend process, toolchain/bootstrap, build, product tests, broad ValidationRunner or CI dispatch. Producer clearance of 442 PNGs is not independent review of all 442; the parent independently opened only three specific new images plus the prior eleven-image v2 sample. Original held issue-722 images remain excluded and forbidden.
make testandmake checkwere not run under this docs-only command lease. Automatic exact-head hosted checks are requested by the PR; documentation path skips are configured skips, not runtime passes. Coordinator review is ledger-diff/metadata review only; this draft grants no readiness, merge or capture authority.Checklist
git commit -s) per the DCOmake test)make check)