Add index generation and change PK generation#11
Add index generation and change PK generation#11sarunast wants to merge 3 commits intoschmunk42:masterfrom
Conversation
Add index generation and change PK generation
|
THanks! I noticed it but handled it on the generated script by hand |
EDatabaseCommand.php
Outdated
There was a problem hiding this comment.
I don't use SQLite so decided to disable it. Just makes migration cleaner.
There was a problem hiding this comment.
Could you set the default to false so we don't break existing commands.
There was a problem hiding this comment.
Does this still work for SQLite?
There was a problem hiding this comment.
I don't know about SQLite sorry.
|
Is there anything which would break backward compatibility or SQLite support? I left a comment at the code line. |
There was a problem hiding this comment.
This if should be moved to line 301. I got a sytnax error unexpected endif when I ran a test.
Could you also verify the changeset by dumping a rather complex MySQL schema and then insert it into SQLite?
|
Got an error when dumping a table without PK, eg. Shouldn't output the last line I think. |
|
schmunk42 feel free to update however you want it, I don't mind. Here is the rep https://github.com/Stamy/database-command. It does completely everything for MySQL, Full FK generation, multiple-keys. |
|
I'll have a detailed look, when I find more time. Thanks. |
Dumping table with MySQL gave my duplicate Primary Keys so I changed the generation.
Also there was no Index generation so I managed to create function which can do that.