Fix: bugs in simulator config, discovery, and broadband source#172
Open
louislva wants to merge 3 commits intosciencecorp:mainfrom
Open
Fix: bugs in simulator config, discovery, and broadband source#172louislva wants to merge 3 commits intosciencecorp:mainfrom
louislva wants to merge 3 commits intosciencecorp:mainfrom
Conversation
…shared by all instances)
… break discoverability
calvinleng-science
approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Welcome, great first contribution! All the fixes are solid; tested locally and everything checks out.
Let us know if you run into anything else, if there's anything in the direction of usability that you would like us to improve on, or features you would like to see.
You should be prompted for the signing of our CLA in the CLA Check workflow. Once that is completed, you will be able to merge.
And again, welcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I was tinkering with the Synapse CLI and found/fixed a few bugs along the way. Here they are, in the same order as the diff shows the files changed:
Configclass storednodesandconnectionson the class rather than the instance/object. This meant every instance ofConfig()would share same values for those two properties, which causes problems if you have multipleConfig()sn_sampleswas calculated