Skip to content

Add getNNodesLeft method#1236

Open
adamj34 wants to merge 2 commits into
scipopt:masterfrom
adamj34:extend-interface
Open

Add getNNodesLeft method#1236
adamj34 wants to merge 2 commits into
scipopt:masterfrom
adamj34:extend-interface

Conversation

@adamj34

@adamj34 adamj34 commented Jul 19, 2026

Copy link
Copy Markdown

Wrap SCIPgetNNodesLeft and append a check to an existing test

@Joao-Dionisio

Copy link
Copy Markdown
Member

Thank you @adamj34 , this looks good! How many other methods did you interface? It may be good to add a bunch at a time, to avoid merging too many PRs and spamming our followers.

@adamj34

adamj34 commented Jul 19, 2026

Copy link
Copy Markdown
Author

@Joao-Dionisio I could interface a few more. I wanted to keep it simple for the first PR but I can add the rest in bulk, as you suggested.

I see that there's an error in the CI pipeline:
error: pyscipopt.scip.Model.getNNodesLeft is not present in stub

Should new methods be added there by hand, or it's supposed to be automated in some way (by the .pre-commit-config.yaml hook, possibly)?

@Joao-Dionisio

Copy link
Copy Markdown
Member

I wanted to keep it simple for the first PR

That's fair, we can merge this one and do the bulk one later.

Should new methods be added there by hand, or it's supposed to be automated in some way (by the .pre-commit-config.yaml hook, possibly)?

We've started working on adding stubs this year, so for now this is still something that needs to be done manually, but hopefuly not for much longer. There is a stub generator, but it's not working yet.

@adamj34

adamj34 commented Jul 19, 2026

Copy link
Copy Markdown
Author

ok, I've added it manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants