Skip to content

OKD-380: Add missing namespace to image trigger annotations#171

Merged
phracek merged 1 commit into
sclorg:5.Xfrom
pskrbasu:fix/image-trigger-namespace-5.X
Jun 23, 2026
Merged

OKD-380: Add missing namespace to image trigger annotations#171
phracek merged 1 commit into
sclorg:5.Xfrom
pskrbasu:fix/image-trigger-namespace-5.X

Conversation

@pskrbasu

Copy link
Copy Markdown
Contributor

Backport of #169 to the 5.X branch.

Add "namespace":"${NAMESPACE}" to the image.openshift.io/triggers annotation's from object on the database Deployment in both cakephp-mysql and cakephp-mysql-persistent templates. Without it, the image trigger controller looks for ImageStreams in the user's namespace instead of openshift, causing image resolution to fail.

Related: okd-project/okd#2337

The image.openshift.io/triggers annotation on database Deployments is
missing the namespace field in the ImageStreamTag reference. Without it,
the image trigger controller looks for ImageStreams in the user's namespace
instead of 'openshift', causing image resolution to fail.

Add "namespace":"${NAMESPACE}" to the trigger from object in both
cakephp-mysql and cakephp-mysql-persistent templates.

Related: okd-project/okd#2337

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02b9d292-5212-417f-981d-9387a950d4dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@phracek phracek merged commit 4a1ae77 into sclorg:5.X Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants