OKD-380: Add missing namespace to image trigger annotations#101
Conversation
The image.openshift.io/triggers annotation on database Deployments is
missing the namespace field in the ImageStreamTag reference. Without it,
the image trigger controller looks for ImageStreams in the user's namespace
instead of 'openshift', causing image resolution to fail.
Add "namespace":"${NAMESPACE}" to the trigger from object in
dancer-mysql-persistent template.
For dancer-mysql template (ephemeral variant): the database Deployment had
"image": " " but was entirely missing the image.openshift.io/triggers
annotation — image resolution could never fire. Add the full trigger
annotation with namespace, and add the missing MYSQL_VERSION parameter
(default "8.0-el8").
Related: okd-project/okd#2337
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 59 minutes and 35 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[test] |
2 participants
Problem
Deploying Dancer+MySQL from the OKD 4.22 Software Catalog fails with:
Reported in okd-project/okd#2337
Root Cause
When templates were migrated from
DeploymentConfigtoDeployment, theimage.openshift.io/triggersannotation on the MySQL database Deployment dropped thenamespacefield from theImageStreamTagreference. Without it, the image trigger controller defaults to the Deployment's own namespace instead ofopenshift, so it can't find the ImageStream and the container image is never resolved.Fix
dancer-mysql-persistent: Add"namespace":"${NAMESPACE}"to the trigger annotation'sfromobject on the database Deploymentdancer-mysql(ephemeral variant): The database Deployment had"image": " "but was entirely missing theimage.openshift.io/triggersannotation — image resolution could never fire. Add the full trigger annotation with namespace. Also add the missingMYSQL_VERSIONparameter (default"8.0-el8")Impact
These template files are the upstream source for
openshift/library(viamake import) and ultimatelyopenshift/cluster-samples-operator. An immediate fix was applied directly to the operator in openshift/cluster-samples-operator#701. This upstream fix ensures the bug doesn't recur on the next sync.