RETURN_TIME_AS_PERIOD for relative times with hours/minutes/seconds#1044
Open
miseran wants to merge 1 commit intoscrapinghub:masterfrom
Open
RETURN_TIME_AS_PERIOD for relative times with hours/minutes/seconds#1044miseran wants to merge 1 commit intoscrapinghub:masterfrom
miseran wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a relative time with granularity less than a day will still result in a period of
day, even whenRETURN_TIME_AS_PERIODis set:This PR changes that behaviour, so that a period of
timeis is returned in this case.The PR doesn't change the behaviour when
RETURN_TIME_AS_PERIODis false. This means thatin 2 months and 2 hoursresults in periodmonth, even though the actual granularity is much finer. I find this counter-intuitive, however there are tests for this, so I kept that behaviour.