Fix spaces in langs with no word spacing#917
Open
noviluni wants to merge 2 commits intoscrapinghub:masterfrom
Open
Fix spaces in langs with no word spacing#917noviluni wants to merge 2 commits intoscrapinghub:masterfrom
noviluni wants to merge 2 commits intoscrapinghub:masterfrom
Conversation
Gallaecio
reviewed
Apr 29, 2021
Member
Gallaecio
left a comment
Gallaecio
left a comment
There was a problem hiding this comment.
The change looks good to me, but the test error seems legit. I wonder if it has anything to do with no_word_spacing.
Collaborator
Author
|
Yes... the Thai test failing in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some regexes come from the CLDR corpus and contain spaces that should be optional. I modified the
write_complete_data.pyscript to override them with optional spaces in those languages where the spaces are optional (indicated withno_word_spacing).Apart from that, I added the
no_word_spacingflag to Thai, as the spaces are optional, and in the case of Thai I also added a new word for "ago".Finally, I added some tests from the examples provided in the issues below.