Fixing: flake8 E402 and windows setup.py not working

[gavishpoddar]

This PR Fixes,

• Fixing E402 module-level import, not at top of file in dateparser/docs/conf.py
• Fixing UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 1442: character maps to in Windows

Note: This change makes it possible to run pip install . . But tox is not entirely fixed.

Please suggest.

[codecov]

Codecov Report

Merging #955 (e36d79b) into master (41f9478) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2694           
=======================================
  Hits         2648     2648           
  Misses         46       46           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f9478...e36d79b. Read the comment docs.

[Gallaecio]

The fixes seem safe to me.

[noviluni]

From what I read in the comments:

Insert the project root dir as the first element in the PYTHONPATH.
This lets us ensure that the source package is imported, and that its
version is used.

I think that this import is here intentionally. I'm not sure if moving it from here would have any adversarial consequence. Wouldn't be better to change it to...

import dateparser  # noqa: E402

just in case? @Gallaecio

[noviluni]

BTW, I've seen that in parsel has the import above, so maybe I'm worrying unnecessarily:

https://github.com/scrapy/parsel/blob/master/docs/conf.py

[Gallaecio]

I had not thought of that. Indeed, having it after will prevent a system-wide-installed version of dateparser being used instead.

It should not be a problem when using tox though, I believe, since tox installs the project into its virtual environment every time.

[noviluni]

I prefer to keep it where it was to avoid needing to modify the comments, etc.

@gavishpoddar could you move it again where it was and add the "noqa"?:

import dateparser # noqa: E402

Thanks!

[gavishpoddar]

Done 👍🏻

[noviluni]

Could you remove the dateparser/docs/conf.py E402 line from the pytest.ini?

thanks!

[gavishpoddar]

Hi, I have made the changes

[kishan3]

It shows "No newline at the end of file" so we need to add it.

[gavishpoddar]

Hi @kishan3, Currently dateparser doesn't have newlines at the end .ini files please suggest should I add them with this PR

Note: The tests are not failing without newline at the end of file