Fix specificity for :is and :where with a preceding selector#163
Closed
Herrtian wants to merge 1 commit intoscrapy:masterfrom
Closed
Fix specificity for :is and :where with a preceding selector#163Herrtian wants to merge 1 commit intoscrapy:masterfrom
Herrtian wants to merge 1 commit intoscrapy:masterfrom
Conversation
Herrtian
force-pushed
the
fix-is-where-specificity
branch
from
530c82d to
fae08bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
This keeps the specificity from the selector before
:is()and:where(). The:is()argument specificity is still added using the most specific argument, while:where()only contributes zero for its own argument list.Checked with:
uv run --with pytest --with lxml pytest tests/test_cssselect.py::TestCssselect::test_specificity -quv run --with pytest --with lxml --with sybil pytest tests -quv run --with ruff ruff check cssselect/parser.py tests/test_cssselect.pyuv run --with tox tox -e typing -- cssselect/parser.py tests/test_cssselect.py