Add protection against failure to reserve jobs#41
Conversation
720e374 to
fdc55bf
Compare
fdc55bf to
e53381c
Compare
|
All right, this version works for a wrong query in the consumers. Here is an example by adding a non existing column: Though technically, in its current state, it says it will reenqueue tasks even if there are no tasks (and the error will pop every so often, but that's ok: it's pretty bad to have a query that fails even when there are no actual jobs to run), so I suspect we need two different |
1006cf5 to
0d15769
Compare
|
Latest commit also guarantees it doesn't fail when a single job fails to parse (without blocking the others). However, the update logic doesn't seem to work yet for some reason :( |
33b0e21 to
b47da37
Compare
|
Build errors are unrelated (but I suspect we're missing some lib install in the CI). This works, and is tested. Now, the main issue is having all these rollbacks / commit in the middle of the consumer loop - it's not great. Another solution would be to have a savepoint, but I think it actually makes sense to rollback in this context. @arybczak any opinion or better solutions ? |
WIP