Fix AttributeError when design is a DataFrame#443
Merged
grst merged 1 commit intoscverse:mainfrom Apr 21, 2026
Merged
Conversation
When DeseqDataSet is created with a precomputed design matrix (DataFrame) instead of a formula string, cond() and contrast() raise a confusing AttributeError because formulaic_contrasts is never set. Added guard with a clear error message directing users to pass contrast vectors directly, matching the existing pattern used for the variables property. Fixes scverse#440.
Ekin-Kahraman
force-pushed
the
fix/dataframe-design-attributeerror
branch
from
a8012f7 to
e7f7366
Compare
grst
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440.
When
DeseqDataSetis created with a precomputed design matrix (DataFrame) instead of a formula string,cond()andcontrast()raise a confusingAttributeError: 'DeseqDataSet' object has no attribute 'formulaic_contrasts'.Added try/except guards with clear error messages directing users to pass contrast vectors directly. Follows the same pattern already used for the
variablesproperty (line 341-347).