MultiPolygons with holes are broken #333

Activity

1. timtreis

   self-assigned this

   on Aug 28, 2024
2. timtreis

   added

   bugSomething isn't workingSomething isn't working

   priority: high

   shapes 🫧Anything related to ShapesAnything related to Shapes

   on Aug 28, 2024
3. timtreis

   linked a pull request that will close this issueDonut-MultiPolygons are now correctly rendered again #334on Aug 28, 2024
4. timtreis

   closed this as completedin #334on Aug 28, 2024
5. quentinblampey commented on Jun 5, 2025

   

   quentinblampey

   on Jun 5, 2025

   More actions

   Hi @timtreis,

   With the latest spatialdata-plot version, I still have issues displaying holes. Is it expected?

   from shapely import Polygon
   from geopandas import GeoDataFrame
   from spatialdata import SpatialData
   from spatialdata.models import ShapesModel
   import spatialdata_plot
   
   ext = [(0, 0), (0, 1), (1, 1), (1, 0), (0, 0)]
   interior = [(0.1, 0.1), (0.1, 0.9), (0.9, 0.9), (0.9, 0.1), (0.1, 0.1)]
   polygon = Polygon(ext, [interior])
   
   geo_df = GeoDataFrame(geometry=[polygon])
   
   sdata = SpatialData(shapes={"test": ShapesModel.parse(geo_df)})
   
   sdata.pl.render_shapes("test").pl.show()

   

   While the polygon should look like this:

   
6. timtreis

   reopened this on Jun 5, 2025
7. timtreis commented on Jun 5, 2025

   

   timtreis

   on Jun 5, 2025

   MemberAuthor

   More actions

   No, and our testing should've caught that. I'll investigate. Thanks for reporting!

   👍React with 👍1Reacted by Quentin Blampey
8. timtreis commented on Jun 6, 2025

   

   timtreis

   on Jun 6, 2025

   MemberAuthor

   More actions

   Wait, you're initialising this as a Shapely.Polygon. Try again with Shapely.MultiPolygon
9. quentinblampey commented on Jun 6, 2025

   

   quentinblampey

   on Jun 6, 2025

   More actions

   Indeed @timtreis it works if I replace Polygon(ext, [interior]) by MultiPolygon([Polygon(ext, [interior])])

   But I guess the case of a single Polygon with a hole should also work, right? When I have a single polygon with a hole, I prefer not to wrap it into a multi-polygon of 1 polygon!
10. timtreis commented on Jun 6, 2025

    

    timtreis

    on Jun 6, 2025

    MemberAuthor

    More actions

    Hm, I guess so far we've been assuming that Polygons don't have holes. Checking the Shapely doc it seems to explicitly allow that. Yeah, we might have to change our logic there.

    cc @Sonja-Stockhaus

    👍React with 👍3Reacted by Quentin Blampey, Arne Defauw and Frank Vernaillen
11. timtreis

    linked a pull request that will close this issuePolygons with holes are now rendered correctly #513on Nov 17, 2025
12. timtreis

    closed this as completedin #513on Nov 19, 2025