Merged
Conversation
Lorak-mmk
approved these changes
Feb 1, 2026
The asynctest package is unmaintained since 2020 and incompatible with Python 3.12+. Replace asynctest.TestSelector with a MagicMock using selectors.BaseSelector as its spec, which provides the same mock selector functionality needed by the asyncio reactor tests. Fixes #663
Increase timer tolerance from 150ms to 500ms to account for CI environments under heavy load, especially Windows during wheel building where timing can be significantly less precise.
dkropachev
force-pushed
the
remove-asynctest-dependency
branch
from
e8b91ef to
caf2f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asynctestdependency (last release 2020, incompatible with Python 3.12+)asynctest.TestSelectorwithMagicMock(spec=selectors.BaseSelector)in asyncio reactor testsunittest.mockandselectorsmodulestest_multi_timer_validationtest on Windows CI by increasing timer tolerance from 150ms to 500msTest plan
asynctestin codebaseuv run pytest tests/unit/io/test_asyncioreactor.pyuv run pytest tests/unit/io/test_twistedreactor.py::TestTwistedTimer::test_multi_timer_validationFixes #663