(Improvement) Remove CQL binary protocol v3#686
Draft
mykaul wants to merge 1 commit intoscylladb:masterfrom
Draft
(Improvement) Remove CQL binary protocol v3#686mykaul wants to merge 1 commit intoscylladb:masterfrom
mykaul wants to merge 1 commit intoscylladb:masterfrom
Conversation
No one needs it anymore. Any reasonable version of Cassandra and ScyllaDB support CQL binary protocol v4 (or higher). This also assume that we test against Cassandra 2.2 or above, so removed some <= 2.1 items. Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
59ebff4 to
3694533
Compare
Author
|
I'm very proud of: |
Author
In theory, you are right. In practice - Scylla uses and supports v4, who is going to use v3 against it? and if they do, why would they upgrade their driver? but generally - fair point - we need to deprecate it in docs or something first. I'll get it to 2026.1 hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No one needs it anymore. Any reasonable version of Cassandra and ScyllaDB support CQL binary protocol v4 (or higher).
This also assume that we test against Cassandra 2.2 or above, so removed some <= 2.1 items.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.