WIP: proposal for a way to configure dimmer colors

[fditolla]

proposal for a way to configure colors that are more readable on light terminals, using a config variable named 'sdkman_colour_style' defaulting to 1 and that when set to 2 uses dimmer colors suitable to white/light colored terminals. (I could not add the variable to the script executed upon installation since it is not under configuration here).

[marc0der]

I like the idea, but think it might be more beneficial if the colour be turned off completely. I like the use of the variable, but would probably call it something like sdkman_colour_enable.

[fditolla]

sdkman_colour_enable=true is already included in the config file, and it works correctly, this was to change the color to dim them, alternatively you could put a fixed "2" in place of the variable I introduced in the colored echo

[marc0der]

Evidently, it's been a while since I implemented that :-)

Would it be possible to somehow make the config read something like:

sdkman_colour_style=dark/light

That would be more intuitive for people trying to configure this.

[fditolla]

I've committed the change you suggested.
I've seen the new indication on contributions: apologies for not having posted in gitter before branching and proposing the change.

[marc0der]

Looking better, although as it stands it will default to the light configuration (since sdkman_colour_style has never been set explicitly.

We require some further work to be done in the sdkman-hooks service to add this new configuration to the config file.

Don't worry about the Gitter bit, this is a new process that was introduced only after you raised your PR ;-)