Repository navigation
Propose richer navigation and values in the listing - #633
Merged
Merged
Conversation
Two changes for the language server, planned but not implemented. find-what-jumps-here-and-rename-a-variable fixes an asymmetry: the server takes the user from a jump to the line it names, but not back, and reports a variable's uses without being able to change them. The scan that answers "what counts as a jump" is already shared by renumbering and jump-to-definition; the change makes it answerable by position rather than adding a third scan beside them. Renaming is bound to the uses already reported, and a rename the machine would not survive - a name it reads as a keyword, or one it would store as a variable the program already has - is refused in the machine's own words. show-a-stopped-programs-values-in-the-listing puts a value beside the name it belongs to. The server holds no machine and reports none: it says where each variable is written and what to look it up as, and the editor resolves that against the session it is already stopped on. The name reported is the one the machine answers to rather than the spelling in the listing, because a machine keeping two characters of a name cannot answer to five. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Vd1pHWCUt3giHynuNAtEy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes for the language server, planned but not implemented.
find-what-jumps-here-and-rename-a-variable fixes an asymmetry: the server
takes the user from a jump to the line it names, but not back, and reports
a variable's uses without being able to change them. The scan that answers
"what counts as a jump" is already shared by renumbering and
jump-to-definition; the change makes it answerable by position rather than
adding a third scan beside them. Renaming is bound to the uses already
reported, and a rename the machine would not survive - a name it reads as a
keyword, or one it would store as a variable the program already has - is
refused in the machine's own words.
show-a-stopped-programs-values-in-the-listing puts a value beside the name
it belongs to. The server holds no machine and reports none: it says where
each variable is written and what to look it up as, and the editor resolves
that against the session it is already stopped on. The name reported is the
one the machine answers to rather than the spelling in the listing, because
a machine keeping two characters of a name cannot answer to five.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_013Vd1pHWCUt3giHynuNAtEy