Skip to content

check, ovs, helpers: fix the seven defects found by the test suite #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insatomcat merged 6 commits into from
Sep 14, 2026
Merged

check, ovs, helpers: fix the seven defects found by the test suite #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f3819b
check: make the duplicate NIC guard span the configuration
insatomcat Sep 7, 2026
78228f4
check: fix three defects in the port attribute validation
insatomcat Sep 7, 2026
1a2239f
helpers: run the command when the caller passes check
insatomcat Sep 7, 2026
34be10f
ovs: build trunks and remote_port from their validated types
insatomcat Sep 7, 2026
8f602fd
README: drop the paragraph about the xfail markers
insatomcat Sep 7, 2026
1a93e5c
check: split _check_port_configuration into per-concern helpers
insatomcat Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ pytest --cov=setup_ovs --cov-report=term-missing --cov-report=xml
Branch coverage is enabled in `pyproject.toml`, so the report covers both
the statement and the branch criteria.

A handful of tests are marked `xfail(strict=True)`. Each one documents a bug
found while writing the suite and pins the current, wrong behaviour: the
suite fails again the day the bug is fixed, which forces the marker to be
removed along with the fix. Their `reason` field states the defect.

## Reproducible build

The wheel is byte-for-byte reproducible provided `SOURCE_DATE_EPOCH` is set.
Expand Down
Loading