Fix: escaped pipe in table wikilinks leaves trailing backslash in URL path#184
Open
Nick-LCY wants to merge 1 commit into
Open
Fix: escaped pipe in table wikilinks leaves trailing backslash in URL path#184Nick-LCY wants to merge 1 commit into
Nick-LCY wants to merge 1 commit into
Conversation
… path
When [[file.md\|Label]] is used inside a Markdown table, the backslash
escape is left in the file path after splitting on '|', causing browsers
to normalize it to '/', resulting in a broken URL like {host}/file.md/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wikilinks with display names use
|as a separator:[[file.md|Label]]. When used inside a Markdown table, the pipe must be escaped to avoid being parsed as a column delimiter:[[file.md\|Label]].inlineInternalLink()splits on|usingexplode(), leaving a trailing backslash in the file path ($linkFile = "file.md\"). Browsers normalize\to/in URL paths, turning the href into{host}/file.md/, which resolves as a directory and fails to find the file.Example
Fix
Strip the trailing backslash from
$linkFileafter splitting:The backslash in | is a Markdown escape character with no meaning in the file path itself. This makes [[file.md|Label]] behave identically to [[file.md|Label]].
Impact