Repository navigation
CI: run the unit tests on every PR - #29
Merged
Merged
Conversation
The offline unit tests ran only in the release workflow, after a tag was pushed, so 0.3.0's version left behind in sqlalchemy_seerdb/__init__.py passed PR CI and failed only on the tag. The Package job now runs them too, on every Python in its matrix, as AGENTS.md already said it did. Closes seerdb#28 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
force-pushed
the
ci-unit-tests-on-pr
branch
from
October 13, 2026 16:50
72aab3b to
75c964c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Package job now also runs the offline unit tests (
python -m unittest -v), on every Python in its matrix. Until now they ran only in the release workflow, after a tag was pushed. That's how 0.3.0's stale__version__passed PR CI (#26) and failed only on the tag (#27).Until #27 merges, this PR's Package jobs fail on
test_version: master still has__version__ = '0.2.2'againstversion = "0.3.0". That failure is the guard working. Once #27 is in, re-run or rebase this one and it goes green.Closes #28
🤖 Generated with Claude Code