fix(release): use PragSys signing identity - #146
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates macOS signing validation to PragSys Collaborative LLC, resolves DuckDB native packages with Bun, and packages architecture-specific desktop sidecars and resources in the self-host image. ChangesRelease packaging updates
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant DockerBuild
participant BuildSidecar
participant RuntimeImage
DockerBuild->>BuildSidecar: Pass architecture-specific Bun target
BuildSidecar->>DockerBuild: Build desktop sidecar and resources
DockerBuild->>RuntimeImage: Copy desktop node_modules and resources
RuntimeImage->>RuntimeImage: Set SELFTUNE_DESKTOP_RESOURCE_DIR=/app
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the two blockers exposed by the v0.3.1 release candidate.
Verified with focused release and Desktop tests, Desktop and self-host typechecks, self-host tests, lint/format, a compiled self-host readiness proof, and a local package run that selected the PragSys Developer ID identity.