Repository navigation
fix(mcp, ticket-112): validate receipt IDs before cleanup effects - #145
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head 598ad8fc96a3ee4e92a12b97b57d6f0b999a814d.
Ticket: ticket-112
Correlation ID: fixos112-598ad8f-20261031
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Fix tightens MCP receipt request-id validation. A shared _validated_request_id enforces a strict anchored portable-identifier regex (max 128 chars, must start alphanumeric) plus explicit '..' rejection before any receipt directory access or cleanup in both task_status and run_fixos_auto_cleanup; generated UUID-based IDs remain valid. The JSON schema description and maxLength are updated for client-side guidance. New tests cover traversal, absolute/Windows-style paths, NUL, overlength, both dry-run and real execution, JSON-RPC error surfacing, and generated-ID replay. No runtime deps added; changes stay within declared allowed paths.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: da980fac5189756b29d6c987c293c8e793014ad9...598ad8fc96a3ee4e92a12b97b57d6f0b999a814d
Change digest: 798c8de66fd620b4d2df5ab1e001d31b4bba78ac62c1cede3f18f582f926706b
Score: 52/100 (M), estimated 60 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":209,"base_sha":"da980fac5189756b29d6c987c293c8e793014ad9","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"798c8de66fd620b4d2df5ab1e001d31b4bba78ac62c1cede3f18f582f926706b","comparison":"da980fac5189756b29d6c987c293c8e793014ad9...598ad8fc96a3ee4e92a12b97b57d6f0b999a814d","deletions":3,"file_count":4,"files":["fixos/mcp_server.py","project/ticket-112/README.md","project/ticket-112/intent.json","tests/unit/test_mcp_server.py"],"head_sha":"598ad8fc96a3ee4e92a12b97b57d6f0b999a814d","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":60,"within_budget":false},"impact":{"components":["absolute","fixos","project","repository-root","tests"],"files":["absolute/Windows","escaped","fixos/mcp_server.py","project/ticket-112/README.md","project/ticket-112/intent.json","tests/unit/test_mcp_server.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":52,"split":{"parts":[{"estimated_minutes":10,"name":"Implement absolute","scope":["absolute"]},{"estimated_minutes":10,"name":"Implement fixos","scope":["fixos"]},{"estimated_minutes":10,"name":"Implement project","scope":["project"]},{"estimated_minutes":10,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":10,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-112"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-112: fix(mcp, ticket-112): validate receipt IDs before cleanup effects</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 60m</text></svg>DECISION D-112-4513
TICKET ticket-112
HEAD_SHA 598ad8fc96a3ee4e92a12b97b57d6f0b999a814d
CORRELATION_ID fixos112-598ad8f-20261031
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test-summary=PASS","test-debian=PASS","test-ubuntu=PASS","test-fedora=PASS","test-arch=PASS","governance / remote lifecycle=PASS","test (3.12)=PASS","governance / enforce=PASS","test (3.10)=PASS","test-alpine=PASS","test (3.11)=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.10)","test (3.11)","test (3.12)","test-summary"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/fixos","pull_request":145,"head_sha":"598ad8fc96a3ee4e92a12b97b57d6f0b999a814d","base_sha":"da980fac5189756b29d6c987c293c8e793014ad9","diff_sha256":"3ed8263bac33ba30cf98a67d681e88fcb3b114894fd67ed9970e94e072491bff"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["fixos/mcp_server.py","project/ticket-112/README.md","project/ticket-112/intent.json","tests/unit/test_mcp_server.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"da980fac5189756b29d6c987c293c8e793014ad9","head_sha":"598ad8fc96a3ee4e92a12b97b57d6f0b999a814d","change_digest":"798c8de66fd620b4d2df5ab1e001d31b4bba78ac62c1cede3f18f582f926706b","score":52,"complexity":"M","estimated_minutes":60,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
FixOS MCP accepted receipt identifiers such as
../escaped, allowing a receipt to be written outside its configured directory even during dry-run. The same portable identifier validation now protects readback and execution before any receipt access, scanning, or cleanup.Regression checks cover traversal, absolute/Windows paths, NULs, length bounds, both execution modes, JSON-RPC errors and generated-ID replay.
Validation: 36 focused MCP tests, Ruff (including import sorting), managed governance, and the full governed Goal suite. Ticket: ticket-112.
Publication is delegated to the protected independent Validator for this exact head. Contributor credentials must not perform the merge.