Skip to content

fix(application): diagnose disagreeing managed version sources explicitly (ticket-216) - #219

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/216-diagnose-disagreeing-version-sources
Oct 25, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/216-diagnose-disagreeing-version-sources

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • Mid-release states (integration version files merged, application banner pending) produced a generic/confusing message.
  • The governed boundary now reports Managed version sources disagree (2.2.4, 2.2.5): land the remaining coordinated release tickets….

Validation

  • completion module — 17 passed (1 new)
  • full suite green; ./project/governance-check.sh — PASS

…itly (ticket-216)

- A coordinated governed release lands its version projection across
  workstream tickets; between merges the managed declarations disagree
  and goal -a answered generically (or with the confusing clean
  force-publish error).
- The pull-request boundary now names the exact values and the remaining
  coordinated release tickets.
- Tests: 17 in the completion module (1 new); full suite green;
  governance check PASS.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 08dba6c565c9ecb04e08f027af16325051aab697.

Ticket: ticket-216
Correlation ID: local-semcod-goal-pr-219-ticket-216
Model: gemini/gemini-3.8-flash
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The PR adds explicit diagnostic error messaging when managed version sources disagree during pull-request delivery workflows, preventing confusing generic error messages during coordinated multi-ticket releases. Tests and ticket governance artifacts are properly included.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: ffb8cb135f8effe2d7129c0a8d9cdb708cafb0ee...08dba6c565c9ecb04e08f027af16325051aab697
Change digest: d7cb4cab9d13c99e67b3795f0bd2f21187371b96d81b71c363b3fa4ca7b87802
Score: 68/100 (L), estimated 66 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":177,"base_sha":"ffb8cb135f8effe2d7129c0a8d9cdb708cafb0ee","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"d7cb4cab9d13c99e67b3795f0bd2f21187371b96d81b71c363b3fa4ca7b87802","comparison":"ffb8cb135f8effe2d7129c0a8d9cdb708cafb0ee...08dba6c565c9ecb04e08f027af16325051aab697","deletions":0,"file_count":5,"files":["goal/push/core.py","project/TICKETS.md","project/ticket-216/README.md","project/ticket-216/intent.json","tests/test_push_workflow_completion.py"],"head_sha":"08dba6c565c9ecb04e08f027af16325051aab697","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":3,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":66,"within_budget":false},"impact":{"components":["generic","goal","project","tests"],"files":["generic/confusing","goal/push/core.py","project/TICKETS.md","project/governance-check.sh","project/ticket-216/README.md","project/ticket-216/intent.json","tests/test_push_workflow_completion.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":68,"split":{"parts":[{"estimated_minutes":14,"name":"Implement generic","scope":["generic"]},{"estimated_minutes":14,"name":"Implement goal","scope":["goal"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-216"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-216: fix(application): diagnose disagreeing managed version sources explicitly (ticket-216)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 105,51 79,85 54,78 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 66m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-216-8642
TICKET ticket-216
HEAD_SHA 08dba6c565c9ecb04e08f027af16325051aab697
CORRELATION_ID local-semcod-goal-pr-219-ticket-216
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.12)=PASS","governance / enforce=PASS","test (3.13)=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.12)","test (3.13)","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/goal","pull_request":219,"head_sha":"08dba6c565c9ecb04e08f027af16325051aab697","base_sha":"ffb8cb135f8effe2d7129c0a8d9cdb708cafb0ee","diff_sha256":"89297d7eaa356b41e76131c9a56c3f289451f20016ef54442b304fd33a5bb52a"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["goal/push/core.py","project/TICKETS.md","project/ticket-216/README.md","project/ticket-216/intent.json","tests/test_push_workflow_completion.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"ffb8cb135f8effe2d7129c0a8d9cdb708cafb0ee","head_sha":"08dba6c565c9ecb04e08f027af16325051aab697","change_digest":"d7cb4cab9d13c99e67b3795f0bd2f21187371b96d81b71c363b3fa4ca7b87802","score":68,"complexity":"L","estimated_minutes":66,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "gemini/gemini-3.8-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 7607bf6 into main Oct 25, 2026
5 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/216-diagnose-disagreeing-version-sources branch October 25, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant