Repository navigation
fix(index): close SQLite connections and preserve busy rebuild owners - #321
Merged
ifuri-validator-agent[bot] merged 2 commits intoOct 30, 2026
Merged
Conversation
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40.
Ticket: ticket-260
Correlation ID: codex-planfile260-reviewed-head-20261030
Model: openai/cursor-auto
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). The visible changes correctly ensure SQLite connections are closed after transaction completion and on connection setup failure, centralize conservative BUSY/LOCKED classification, and prevent contention during rebuild from being misclassified as corruption and triggering an unsafe reset. No unresolved correctness or security defects are evident in this chunk. | The visible ticket metadata and regression tests correctly cover deterministic SQLite connection closure, transaction commit/rollback behavior, setup-failure cleanup, and preservation of an independently locked database during BUSY/LOCKED rebuild failures. No unresolved code or security defects are evident in this chunk. | The visible test addition introduces tracking infrastructure for bounded-batch rebuild validation and contains no evident correctness or security defect. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 9a221c92dc42a104c2347ad5b507128ded696648...af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40
Change digest: e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913
Score: 76/100 (L), estimated 113 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":317,"base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913","comparison":"9a221c92dc42a104c2347ad5b507128ded696648...af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","deletions":36,"file_count":6,"files":["planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","tests/test_sqlite_ticket_index.py"],"head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":5,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":113,"within_budget":false},"impact":{"components":["BUSY","and100status","commit","database","index","planfile","project","resetting","tests"],"files":["BUSY/LOCKED","and100status/current","commit/rollback","database/lock","index/retry","planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","resetting/replaying","tests/test_sqlite_ticket_index.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":76,"split":{"parts":[{"estimated_minutes":12,"name":"Implement BUSY","scope":["BUSY"]},{"estimated_minutes":12,"name":"Implement and100status","scope":["and100status"]},{"estimated_minutes":12,"name":"Implement commit","scope":["commit"]},{"estimated_minutes":12,"name":"Implement database","scope":["database"]},{"estimated_minutes":12,"name":"Implement index","scope":["index"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-260"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-260: fix(index): close SQLite connections and preserve busy rebuild owners</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 54,78 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 113m</text></svg>DECISION D-260-4512
TICKET ticket-260
HEAD_SHA af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40
CORRELATION_ID codex-planfile260-reviewed-head-20261030
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / enforce=PASS","test (3.13)=PASS","governance / remote lifecycle=PASS","freshness=PASS","ci-loop=PASS","test (3.10)=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":321,"head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","diff_sha256":"8d67ad56346478cd18180cf63d651e33ec344e82137b5e2980e3113d25a69e70"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","tests/test_sqlite_ticket_index.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","change_digest":"e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913","score":76,"complexity":"L","estimated_minutes":113,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Contributor
There was a problem hiding this comment.
Validator approval after policy checks for exact head af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40.
Ticket: ticket-260
Correlation ID: local-semcod-planfile-pr-321-ticket-260
Model: openai/cursor-auto
Reviewed diff chunks: 3
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 3 diff chunk(s). The visible changes correctly ensure SQLite connections are closed after commit, rollback, and setup failure, centralize conservative BUSY/LOCKED classification, and avoid destructive reset/rebuild behavior when contention indicates another database owner is active. No code or security defect is evident in this chunk. | The visible ticket metadata and regression tests correctly exercise deterministic SQLite connection closure across successful operations, rollback, and setup failures, while verifying that BUSY/LOCKED rebuild contention preserves an independent writer, database inode, and committed data. Extended SQLite result codes and message-based fallback behavior are covered without weakening genuine corruption recovery expectations. | The visible test-only chunk introduces bounded-batch rebuild tracking and reveals no correctness or security defect. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 9a221c92dc42a104c2347ad5b507128ded696648...af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40
Change digest: e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913
Score: 76/100 (L), estimated 113 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":317,"base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","binary_files":0,"categories":{"code":2,"configuration":1,"docs":2,"tests":1},"change_digest":"e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913","comparison":"9a221c92dc42a104c2347ad5b507128ded696648...af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","deletions":36,"file_count":6,"files":["planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","tests/test_sqlite_ticket_index.py"],"head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":5,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":113,"within_budget":false},"impact":{"components":["BUSY","and100status","commit","database","index","planfile","project","resetting","tests"],"files":["BUSY/LOCKED","and100status/current","commit/rollback","database/lock","index/retry","planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","resetting/replaying","tests/test_sqlite_ticket_index.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":76,"split":{"parts":[{"estimated_minutes":12,"name":"Implement BUSY","scope":["BUSY"]},{"estimated_minutes":12,"name":"Implement and100status","scope":["and100status"]},{"estimated_minutes":12,"name":"Implement commit","scope":["commit"]},{"estimated_minutes":12,"name":"Implement database","scope":["database"]},{"estimated_minutes":12,"name":"Implement index","scope":["index"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-260"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-260: fix(index): close SQLite connections and preserve busy rebuild owners</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 54,78 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 113m</text></svg>DECISION D-260-5579
TICKET ticket-260
HEAD_SHA af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40
CORRELATION_ID local-semcod-planfile-pr-321-ticket-260
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / enforce=PASS","test (3.13)=PASS","governance / remote lifecycle=PASS","freshness=PASS","ci-loop=PASS","test (3.10)=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":321,"head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","diff_sha256":"8d67ad56346478cd18180cf63d651e33ec344e82137b5e2980e3113d25a69e70"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/core/sqlite_index.py","planfile/core/store.py","project/TICKETS.md","project/ticket-260/README.md","project/ticket-260/intent.json","tests/test_sqlite_ticket_index.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"9a221c92dc42a104c2347ad5b507128ded696648","head_sha":"af96971d5b3782e1d8e6ca77a1fb48d7afaa3d40","change_digest":"e6fc82e179048703de141c62baa26a8dc2c8559aee7f499015be3e7d0b6e2913","score":76,"complexity":"L","estimated_minutes":113,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
ifuri-validator-agent
Bot
deleted the
ticket/260-sqlite-index-owner-lifetime
branch
October 30, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated SQLite index operations depended on cyclic GC to close connections. A rebuild also treated BUSY/LOCKED as corruption and could replace the index while another writer still held its original database.
Close internal operation connections after transaction commit/rollback and on setup failures. Reuse exact SQLite contention classification and defer a busy rebuild without resetting/replaying it; genuine corruption recovery remains.
Validation:78affected index/retry tests passed via Testless, including12new cases. An independent SQLite writer stays alive with unchanged database inode and committed data, and100status/current reads remain bounded with cyclic GC disabled. Existing post-commit write, stale-CAS and genuine-corruption regressions pass. Pinned Ruff0.15.11 reports0findings (3baseline); managed governance passes.
Ticket: ticket-260
Existing owner:#313; native adoption:#317; parent:PLF-20347. This changes source behavior only. No live database/lock deletion, process termination, native package hotpatch or implicit runtime activation.