Repository navigation
feat(cache, rust): optimize SQLite cache with WAL mode and native fast-hash engine (ticket-013) - #19
Conversation
… in config (ticket-013)
…ocess similarity and SimHash
… signature computation
…ng in native rust tests
There was a problem hiding this comment.
Validator approval after policy checks for exact head beb9c12b5b36e8e7c251155a89dc8285925822bb.
Ticket: ticket-013
Correlation ID: local-semcod-redup-pr-19-ticket-013
Model: zai/glm-5.3
Advisory LLM review: LLM_UNAVAILABLE
Reason: No module named 'litellm'
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 4924ecdb064b652e3b0cbb74cff2988f7de6382e...beb9c12b5b36e8e7c251155a89dc8285925822bb
Change digest: 1a86afc35d99725c5974af8e20727519ee50a489d3222ae49a1a0bc6614c395d
Score: 64/100 (L), estimated 106 min, split recommended: true
Affected services/components: packages/redup-fast-hash
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":800,"base_sha":"4924ecdb064b652e3b0cbb74cff2988f7de6382e","binary_files":0,"categories":{"code":9,"configuration":2,"docs":2,"tests":3},"change_digest":"1a86afc35d99725c5974af8e20727519ee50a489d3222ae49a1a0bc6614c395d","comparison":"4924ecdb064b652e3b0cbb74cff2988f7de6382e...beb9c12b5b36e8e7c251155a89dc8285925822bb","deletions":19,"file_count":16,"files":["packages/redup-fast-hash/Cargo.lock","packages/redup-fast-hash/Cargo.toml","packages/redup-fast-hash/src/lib.rs","packages/redup-fast-hash/src/lsh.rs","project/TICKETS.md","project/ticket-013/README.md","project/ticket-013/intent.json","src/redup/core/cache.py","src/redup/core/config.py","src/redup/core/matcher.py","src/redup/core/models.py","src/redup/core/pipeline/duplicate_finder.py","src/redup/core/tokens_hasher.py","tests/test_scanner.py","tests/test_similarity_rust.py","tests/test_tokens_hasher_rust.py"],"head_sha":"beb9c12b5b36e8e7c251155a89dc8285925822bb","service_count":1,"services":["packages/redup-fast-hash"]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":3,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":106,"within_budget":false},"impact":{"components":["packages/redup-fast-hash","project","src/redup","tests"],"files":["packages/redup-fast-hash/Cargo.lock","packages/redup-fast-hash/Cargo.toml","packages/redup-fast-hash/src/lib.rs","packages/redup-fast-hash/src/lsh.rs","project/TICKETS.md","project/ticket-013/README.md","project/ticket-013/intent.json","src/redup/core/cache.py","src/redup/core/config.py","src/redup/core/matcher.py","src/redup/core/models.py","src/redup/core/pipeline/duplicate_finder.py","src/redup/core/tokens_hasher.py","tests/test_scanner.py","tests/test_similarity_rust.py","tests/test_tokens_hasher_rust.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":24,"name":"Implement packages/redup-fast-hash","scope":["packages/redup-fast-hash"]},{"estimated_minutes":24,"name":"Implement project","scope":["project"]},{"estimated_minutes":24,"name":"Implement src/redup","scope":["src/redup"]},{"estimated_minutes":24,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-013"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-013: feat(cache, rust): optimize SQLite cache with WAL mode and native fast-hash engine (ticket-013)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 97,53 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 106m</text></svg>DECISION D-013-7450
TICKET ticket-013
HEAD_SHA beb9c12b5b36e8e7c251155a89dc8285925822bb
CORRELATION_ID local-semcod-redup-pr-19-ticket-013
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","governance / enforce=PASS","test (3.13)=PASS","test (3.10)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/redup","pull_request":19,"head_sha":"beb9c12b5b36e8e7c251155a89dc8285925822bb","base_sha":"4924ecdb064b652e3b0cbb74cff2988f7de6382e","diff_sha256":"a82f4da6aedb24ea786b9a3cc8b6609a58c0515444c7e6ea04a00e0135897dcb"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["packages/redup-fast-hash/Cargo.lock","packages/redup-fast-hash/Cargo.toml","packages/redup-fast-hash/src/lib.rs","packages/redup-fast-hash/src/lsh.rs","project/TICKETS.md","project/ticket-013/README.md","project/ticket-013/intent.json","src/redup/core/cache.py","src/redup/core/config.py","src/redup/core/matcher.py","src/redup/core/models.py","src/redup/core/pipeline/duplicate_finder.py","src/redup/core/tokens_hasher.py","tests/test_scanner.py","tests/test_similarity_rust.py","tests/test_tokens_hasher_rust.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"4924ecdb064b652e3b0cbb74cff2988f7de6382e","head_sha":"beb9c12b5b36e8e7c251155a89dc8285925822bb","change_digest":"1a86afc35d99725c5974af8e20727519ee50a489d3222ae49a1a0bc6614c395d","score":64,"complexity":"L","estimated_minutes":106,"split_recommended":true,"services":["packages/redup-fast-hash"],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Summary
Closes ticket-013.
PRAGMA journal_mode = WAL; PRAGMA synchronous = NORMAL;and batched file hash commits to eliminate synchronous fsync bottlenecks.redup-fast-hash):find_simhash_candidates) usingu64bucket keys.managed_componentsand added support for user-defined ignore paths.