Repository navigation
chore(ticket-047): remediate PERF-AUDIT findings and adopt wellman standard packs - #47
Conversation
|
Validator semantic assessment is held for head Ticket: These findings are advisory; approval and merge remain blocked. The text grants no execution authority. Findings are bounded to 16 entries of 512 UTF-8 bytes.
|
…ry, runtime, and diagnostics
bd1dece to
13178f6
Compare
There was a problem hiding this comment.
Validator approval after policy checks for exact head 13178f6b70f40f1ba3cbea9bdf604098b9c78bd1.
Ticket: ticket-047
Correlation ID: local-semcod-uncrash-pr-47-ticket-047
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 2 diff chunk(s). Required protected checks pass, and the visible subprocess refactor largely preserves launch behavior. However, the display-bound API change introduces a compatibility regression. | The visible chunk is a behavior-preserving refactor that centralizes restored-application process creation in a local helper. The command, working directory, environment, standard-stream redirection, and new-session behavior remain unchanged. All supplied protected required checks passed.
Advisory findings: src/uncrash/preview.py: _find_free_display(*bounds) no longer accepts the previously valid keyword calls _find_free_display(start=...) or _find_free_display(end=...), which now raise TypeError. Preserve keyword compatibility while removing the audited defaults, or update and validate every caller under the accepted scope.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 3a93e836f61a42f2e0c47e858a6daf09c5e0106b...13178f6b70f40f1ba3cbea9bdf604098b9c78bd1
Change digest: 2e881e74968777aa061b18fec47aca88a32ebd52595aff59e76fda19cf216aec
Score: 44/100 (M), estimated 52 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":99,"base_sha":"3a93e836f61a42f2e0c47e858a6daf09c5e0106b","binary_files":0,"categories":{"code":4,"configuration":1,"docs":2},"change_digest":"2e881e74968777aa061b18fec47aca88a32ebd52595aff59e76fda19cf216aec","comparison":"3a93e836f61a42f2e0c47e858a6daf09c5e0106b...13178f6b70f40f1ba3cbea9bdf604098b9c78bd1","deletions":21,"file_count":7,"files":["project/TICKETS.md","project/ticket-047/README.md","project/ticket-047/intent.json","src/uncrash/diagnostics.py","src/uncrash/preview.py","src/uncrash/recovery.py","src/uncrash/runtime.py"],"head_sha":"13178f6b70f40f1ba3cbea9bdf604098b9c78bd1","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":2,"delivery":1,"scope":3,"uncertainty":4,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":52,"within_budget":false},"impact":{"components":["project","src/uncrash"],"files":["project/TICKETS.md","project/ticket-047/README.md","project/ticket-047/intent.json","src/uncrash/diagnostics.py","src/uncrash/preview.py","src/uncrash/recovery.py","src/uncrash/runtime.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":44,"split":{"parts":[{"estimated_minutes":21,"name":"Implement project","scope":["project"]},{"estimated_minutes":21,"name":"Implement src/uncrash","scope":["src/uncrash"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-047"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-047: chore(ticket-047): remediate PERF-AUDIT findings and adopt wellman standard packs</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 80,59 84,92 59,71 56,61" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 52m</text></svg>DECISION D-047-6895
TICKET ticket-047
HEAD_SHA 13178f6b70f40f1ba3cbea9bdf604098b9c78bd1
CORRELATION_ID local-semcod-uncrash-pr-47-ticket-047
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["governance / enforce","governance / remote lifecycle","onedev/local-verify"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/uncrash","pull_request":47,"head_sha":"13178f6b70f40f1ba3cbea9bdf604098b9c78bd1","base_sha":"3a93e836f61a42f2e0c47e858a6daf09c5e0106b","diff_sha256":"98c6fd66526cf9881d2aa6c61de80f89cd846e3402222fc3a2782303034a4443"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-047/README.md","project/ticket-047/intent.json","src/uncrash/diagnostics.py","src/uncrash/preview.py","src/uncrash/recovery.py","src/uncrash/runtime.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"3a93e836f61a42f2e0c47e858a6daf09c5e0106b","head_sha":"13178f6b70f40f1ba3cbea9bdf604098b9c78bd1","change_digest":"2e881e74968777aa061b18fec47aca88a32ebd52595aff59e76fda19cf216aec","score":44,"complexity":"M","estimated_minutes":52,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Created by governed goal -a pull-request delivery.