This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Conversation
test plan: make
aryx
requested review from
IagoAbal,
brandonspark,
emjin,
kopecs and
mjambon
and removed request for
a team
May 7, 2024 09:21
Author
|
make build works locally on my machine; not sure what are those errors in circleCI :( |
aryx
added a commit
to semgrep/semgrep
that referenced
this pull request
May 8, 2024
The use of FROM:returntocorp/ocaml:..., which are docker images generated by ocaml-layer (https://github.com/semgrep/ocaml-layer/), served us well in the past to speedup CI. However, we now use GHA caching more and depot.dev which removes the need for ocaml-layer. Worse, ocaml-layer adds an extra layer of complexity that is annoying when updating to more recent version of OCaml (e.g., 5.2). For example I had trouble in the past in semgrep/ocaml-layer#46 or #10213 to fix our ocaml-layer. Moreover ocaml-layer relies on circleCI, which we don't support anymore, so it's lots of extra work on ocaml-layer that we don't really need. Let's remove this intermediate. test plan: make build-docker
aryx
added a commit
to semgrep/semgrep
that referenced
this pull request
May 8, 2024
…10224) The use of FROM:returntocorp/ocaml:..., which are docker images generated by ocaml-layer (https://github.com/semgrep/ocaml-layer/), served us well in the past to speedup CI. However, we now use GHA caching more and depot.dev which removes the need for ocaml-layer. Worse, ocaml-layer adds an extra layer of complexity that is annoying when updating to more recent version of OCaml (e.g., 5.2). For example I had trouble in the past in semgrep/ocaml-layer#46 or #10213 to fix our ocaml-layer. Moreover ocaml-layer relies on circleCI, which we don't support anymore, so it's lots of extra work on ocaml-layer that we don't really need. Let's remove this intermediate. test plan: make build-docker
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test plan:
make
PR checklist: