[UIK-5351][theme] Add more variables to theme#3039
Open
j-mnizhek wants to merge 23 commits into
Open
Conversation
github-actions
Bot
added
badge
feature-highlight
base-components
base-trigger
select
time-picker
add-filter
date-picker
button
wizard
side-panel
pagination
notice-bubble
feedback-form
modal
fullscreen-modal
carousel
notice
inline-input
feature-popover
errors
dropdown-menu
data-table
color-picker
card
drag-and-drop
bulk-textarea
labels
ilyabrower
reviewed
Jul 10, 2026
ilyabrower
left a comment
ilyabrower
left a comment
Contributor
There was a problem hiding this comment.
It looks like the tokens are sorted alphabetically, but previously they were sorted by meaning. Were these changes necessary?
Member
Author
Yep, it's necessary for now, alphabetical order is temporary, just for convenience during the updating styles |
Contributor
|
@ilyabrower @j-mnizhek after merge release/v17 i see that new wizard styled not applied Actual: Expected: should be black |
Valeria-Zimnitskaya
self-requested a review
July 13, 2026 13:30
…some theme initial fixes (#3057) ## Changelog ### @semcore/button #### Changed - Styles #### Break - Remove legacy `secondary` `info` theme. ### @semcore/theme #### Changed - Values for color variables - Default height for controls: for M — from 28 to 32. for L — from 40 to 44 ### @semcore/link #### Changed - Styles ### @semcore/modal #### Fixed - Hardcoded margins in Close button. ### @semcore/fullscreen-modal #### Fixed - Hardcoded margins in Close button. ## Motivation and Context **Along with button styles and values for its variables, I had to:** - update comments in some components according to the new variables names we were discussing with girls - remove hardcoded margins in Close button component inside the Modal and FullscreModal - remove hardcoded values for w and h in: BaseTrigger, ColorPicker, InputTags, Input, Notice.Label, Pills, TabLine, TimePicker - updated variables' values and styles of the Link ## How has this been tested? Manually. ## Screenshots (if appropriate): Current: <img width="831" height="477" alt="image" src="https://github.com/user-attachments/assets/d59b0010-13e1-404b-88bc-8de25be28d94" /> Updated: <img width="1024" height="524" alt="image" src="https://github.com/user-attachments/assets/ffcdb9ab-5d09-4821-9d69-87601376f362" /> ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeryia Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: ilia.brauer <ilia.brauer@semrush.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/theme
BREAK
@semcore/accordion
BREAK
@semcore/add-filter
BREAK
@semcore/animation
BREAK
@semcore/badge
BREAK
@semcore/base-trigger
BREAK
@semcore/breadcrumbs
BREAK
@semcore/breakpoints
BREAK
@semcore/bulk-textarea
BREAK
@semcore/button
BREAK
@semcore/card
BREAK
@semcore/carousel
BREAK
@semcore/checkbox
BREAK
@semcore/color-picker
BREAK
@semcore/core
BREAK
@semcore/counter
BREAK
@semcore/d3-chart
BREAK
@semcore/data-table
BREAK
@semcore/date-picker
BREAK
@semcore/divider
BREAK
@semcore/dot
BREAK
@semcore/drag-and-drop
BREAK
@semcore/dropdown
BREAK
@semcore/dropdown-menu
BREAK
@semcore/ellipsis
BREAK
@semcore/errors
BREAK
@semcore/feature-highlight
BREAK
@semcore/feature-popover
BREAK
@semcore/feedback-form
BREAK
@semcore/flags
BREAK
@semcore/flex-box
BREAK
@semcore/fullscreen-modal
BREAK
@semcore/grid
BREAK
@semcore/hint
BREAK
@semcore/icon
BREAK
@semcore/illustration
BREAK
@semcore/inline-edit
BREAK
@semcore/inline-input
BREAK
@semcore/input
BREAK
@semcore/input-mask
BREAK
@semcore/input-number
BREAK
@semcore/input-tags
BREAK
@semcore/link
BREAK
@semcore/mini-chart
BREAK
@semcore/modal
BREAK
@semcore/neighbor-location
BREAK
@semcore/notice
BREAK
@semcore/notice-bubble
BREAK
@semcore/outside-click
BREAK
@semcore/pagination
BREAK
@semcore/pills
BREAK
@semcore/popper
BREAK
@semcore/portal
BREAK
@semcore/product-head
BREAK
@semcore/progress-bar
BREAK
@semcore/radio
BREAK
@semcore/scroll-area
BREAK
@semcore/select
BREAK
@semcore/side-panel
BREAK
@semcore/skeleton
BREAK
@semcore/slider
BREAK
@semcore/spin
BREAK
@semcore/spin-container
BREAK
@semcore/switch
BREAK
@semcore/tab-line
BREAK
@semcore/tab-panel
BREAK
@semcore/tag
BREAK
@semcore/textarea
BREAK
@semcore/time-picker
BREAK
@semcore/tooltip
BREAK
@semcore/typography
BREAK
@semcore/widget-empty
BREAK
@semcore/wizard
BREAK
Motivation and Context
How has this been tested?
Manually.
Types of changes
Checklist: