Skip to content

[UIK-5574][drag-and-drop] rewrite component types to NS#3055

Open
slizhevskyv-semrush wants to merge 3 commits into
release/v17from
UIK-5574/rewrite-component-to-ns
Open

[UIK-5574][drag-and-drop] rewrite component types to NS#3055
slizhevskyv-semrush wants to merge 3 commits into
release/v17from
UIK-5574/rewrite-component-to-ns

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/drag-and-drop

Changed

  • Refactor component types. Deprecated atomic types. Atomic types are part of NSDragAndDrop namespace.

Motivation and Context

Refactor component types. Deprecated atomic types in favor namespaces. Nothing changed in how component works.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

'Draggable'
> & {
// Passed from DropZone.
noDrag?: boolean;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be a public property... let's imagine we could disable the ability to drag and drop an element...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks!

role='group'
aria-describedby={`describe-draggable-${uid}`}
use:keyboardFocused={isCustomFocus ? false : keyboardFocused}
use:keyboardFocused={isCustomFocus || false}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like incorrect...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, as well :)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants