UI k 5551/pills rebranding#3060
Open
slizhevskyv-semrush wants to merge 14 commits into
Open
Conversation
…rand-button-styles
…heme' into UIK-5551/pills-rebranding
slizhevskyv-semrush
changed the base branch from
release/v17
to
UIK-5351/add-more-variables-to-theme
July 21, 2026 09:53
github-actions
Bot
removed
base-components
badge
breadcrumbs
checkbox
d3-chart
divider
dot
dropdown
ellipsis
labels
ilyabrower
reviewed
Jul 21, 2026
| } | ||
| SPillSeparator { | ||
| width: 1px; | ||
| height: 18px; |
Contributor
There was a problem hiding this comment.
what do you think to use here something likecalc(var(--intergalactic-form-control-m) - var(border?) - var(padding) ?
Contributor
Author
There was a problem hiding this comment.
if I get an idea correctly, the separator size should be equal to text's height...
but I don't have any ideas how to achieve this in a simple way....
Contributor
There was a problem hiding this comment.
hey, I think we can try just lh-200 (300 in size L), so that it equals the line height. It's a bit different to the design, but we will look at it live and maybe it'll be fine
Contributor
Author
There was a problem hiding this comment.
@sheila-semrush could you please verify it during Desing Review phase and leave it if it will make sense?
| margin-right: var(--intergalactic-spacing-3x, 12px); | ||
| } | ||
| &[size='l'] { | ||
| height: 24px; |
ilyabrower
reviewed
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Pills rebranding.
How has this been tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: