Skip to content

[UIK-5586] Update Select and DropdownMenu styles#3065

Draft
sheila-semrush wants to merge 1 commit into
UIK-5351/add-more-variables-to-themefrom
UIK-5586/select-rebranding
Draft

[UIK-5586] Update Select and DropdownMenu styles#3065
sheila-semrush wants to merge 1 commit into
UIK-5351/add-more-variables-to-themefrom
UIK-5586/select-rebranding

Conversation

@sheila-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/_$component_name

Fixed

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

display: inline-flex;
align-items: center;
justify-content: center;
gap: var(--intergalactic-spacing-content-gap-medium, 6px);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought it would be more convenient to set it as gap instead of margins for addons

height: var(--intergalactic-spacing-3x, 12px);
color: var(--intergalactic-icon-non-interactive, oklch(0.094 0.024 153.9 / 0.503));
position: relative;
left: var(--intergalactic-spacing-05x, 2px);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to shift the chevron optically 2px closer to the right border

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(additional 2px gap that appears before the chevron is ok)

SBaseTrigger[size='m'] {
min-width: var(--intergalactic-form-control-m, 32px);
height: var(--intergalactic-form-control-m, 32px);
border-radius: var(--intergalactic-control-rounded, 6px);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved styles that are common for both sizes to the common selector, left here only styles that differ in M/L

font-size: var(--intergalactic-fs-200, 14px);

& SAddon {
&:not(:only-child):first-child {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced this with gap for the wrapper

margin-left: var(--intergalactic-spacing-2x, 8px);
}

&:only-child {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this to the SAddon selector

pointer-events: none;
}

SBaseAddon {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed SBaseAddon selector because I don't think it's used anywhere anymore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SButtonAddon is used for chevron instead (in button trigger)

@sheila-semrush sheila-semrush changed the title [base-trigger] updated styles [UIK-5586] updated Select and DropdownMenu styles Jul 22, 2026
@sheila-semrush sheila-semrush changed the title [UIK-5586] updated Select and DropdownMenu styles [UIK-5586] Update Select and DropdownMenu styles Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant