feat(extras): promote 老抽 / プーアール茶 from candidate scan#243
Merged
Conversation
Scanned `dictool candidates mine` (PR #242) output and hand-picked 2 food entries that are genuine Mozc gaps: - ろうちゅう → 老抽 (中華の濃口醤油) Mozc top-1 was 郎中 (final=19063); 老抽 was absent from the build dict. - ぷーあーるちゃ → プーアール茶 Mozc has no compound entry; lattice produced "プーアールちゃ" (mixed script) as top-1. Promoting to a single-word entry pins 茶 as the tail kanji. Skipped during scan: - らおちゅう→老抽 (would demote existing らおちゅう→老酒) - てんめんじゃん→甜麺醤 (Mozc already top-1) - とうち→豆豉 (would demote much-more-common 当地) Build merge log confirms no surface collisions (`+7 readings, +9 entries, 0 replaced`). Accuracy: 77/77 active cases pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR promotes two curated “extras” dictionary entries (老抽 / プーアール茶) identified via candidate-scan output, and adds corresponding accuracy corpus cases to ensure they remain top-1 conversions.
Changes:
- Add
ろうちゅう→老抽andぷーあーるちゃ→プーアール茶to the curated extras food TSV. - Add two
extrascases to the conversion accuracy corpus to lock in expected top-1 outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| engine/testcorpus/accuracy-corpus.toml | Adds 2 new extras accuracy cases for the promoted entries. |
| engine/crates/lex-cli/src/dict_source/extras/food.tsv | Promotes 2 curated food-related entries into the extras dictionary source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- food.tsv: split "中国茶" out from "日本茶ブランド" header so プーアール茶 doesn't sit under a 日本茶-only section - accuracy-corpus.toml: reorder so 老抽 / プーアール茶 (food) stay contiguous with the other food cases instead of being split by 雲母坂 (geography) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #242 で merge した `dictool candidates mine` の出力をスキャンし、Mozc 辞書の真の gap を 2 件のみ promote。
ビルドログ: `Merged 'extras': +7 readings, +9 entries, 0 replaced` で衝突なしを確認。
Scan で除外した候補 (memo)
Accuracy
`mise run accuracy`: 77/77 active pass (skip 1 = 既存)、extras カテゴリ 7→9 cases。`mise run accuracy-history`: 6/6 pass。
Test plan
🤖 Generated with Claude Code