Skip to content

feat(session): open a detail dialog for subagents, workers, and child tasks - #558

Merged
astyfx merged 1 commit into
mainfrom
fix/subagent-model-effort
Sep 18, 2026
Merged

astyfx merged 1 commit into
mainfrom
fix/subagent-model-effort

Conversation

@astyfx

@astyfx astyfx commented Sep 18, 2026

Copy link
Copy Markdown
Member

Summary

Clicking an agent row in the Agent Tree, Collaboration panel, and Turn Activity now opens a read-only detail dialog that shows the assignment, live and saved activity, the result, and the model and reasoning effort in use, instead of only jumping to a turn event.

Changes

Features

  • session: click a subagent, worker, or child-task row to open a detail dialog with the assignment, live/saved activity, and returned result rather than only navigating to a turn event.
  • session: show the model and reasoning effort for each agent, labelled with where the value came from — requested, configured, or runtime-reported — so a displayed value is no longer mistaken for confirmed execution telemetry.
  • provider: add a read-only provider.read-agent-history contract that loads a subagent transcript without resuming, forking, or starting an agent. Claude validates subagent membership via listSubagents before returning messages; Codex reads a stored thread with turns (includeTurns) and rejects a thread from another working directory.

Fixes

  • collaboration: Codex collaboration spawns now carry model and reasoning effort through the activity mapper and resolve the spawned child thread id for spawnAgent.

Refactors / Chores

  • work-graph: AgentNode and the reducer carry model, effort, and modelEvidence; tool-use parts carry agentId, ownerAgentId, and parentToolUseId through replay and the persisted schema.

Breaking Changes

  • None.

Test Evidence

  • bun run typecheck: clean.
  • bun test tests/agent-history.test.ts: 11 pass — request-contract bounds, inert-text handling, provider mapping, and 64 KiB truncation.
  • bun test across the directly-affected suites (agent-history, codex-worker-activity, codex-app-server-runtime, work-graph, delegation/exchange, turn-activity, provider-event-replay): 329 pass, 0 fail.
  • Full-suite bun test: 5843 pass. The 62 failures are load-based timeouts and subprocess-timing flakes (ACP, executable-probe, CDP guest removal, untracked-working-tree diff) in files this PR does not touch; each passes when run outside the saturated full-suite run. check:licenses fails only because license-checker is absent from this worktree's node_modules; no dependency or license file changed.

Notes

  • Transcripts are treated as inert text (never executed or interpreted), oversized entries are truncated at the persisted-event ceiling, and the reader is exposed only as a read path — not a resume, fork, or start. Advisor rows keep their existing dedicated log path.
  • Manual UI verification of the dialog in the packaged renderer is still recommended before release.

… tasks

Clicking an agent row in the Agent Tree, Collaboration panel, and Turn
Activity now opens a read-only detail dialog instead of only jumping to a
turn event. The dialog shows the assignment, live and saved activity, the
returned result, and the model and reasoning effort in use, labelled with
where each value came from (requested, configured, or runtime-reported).

Saved subagent transcripts are loaded read-only over a new
provider.read-agent-history contract: the Claude path validates subagent
membership before returning messages, and the Codex path reads a stored
thread with turns without resuming it and rejects a thread from another
working directory. Transcripts are kept as inert text, oversized entries
are truncated at the persisted-event ceiling, and the reader is never
exposed as a resume, fork, or start path. Advisor rows keep their existing
dedicated log path.
@astyfx
astyfx requested a review from a team as a code owner September 18, 2026 04:43
@astyfx
astyfx requested review from JongSikLim and heath-s and removed request for a team September 18, 2026 04:43
@astyfx
astyfx enabled auto-merge (squash) September 18, 2026 04:43
@upwind-code-us

upwind-code-us Bot commented Sep 18, 2026

Copy link
Copy Markdown

Upwind Upwind Code Scan - ✅ Passed

0 newly introduced vulnerabilities · 0 resolved · 57 total in this PR vs main

Total breakdown: 🔶 6 High | 🟡 48 Medium | 🟢 3 Low

View full analysis in Upwind Console

Scan completed in 10s

Scan history (1 scan)
Commit Scanned at New Resolved Net
ff1361e < 2026-09-18 04:43 UTC 0 0 0

Last scanned: ff1361e · 2026-09-18 04:43 UTC

@upwind-code-us

upwind-code-us Bot commented Sep 18, 2026

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Passed

0 newly introduced misconfigurations · 0 resolved · 0 total in this PR vs main

View full analysis in Upwind Console →

Scan completed in 6s

Scan history (1 scan)
Commit Scanned at New Resolved Net
ff1361e < 2026-09-18 04:44 UTC 0 0 0

Last scanned: ff1361e · 2026-09-18 04:44 UTC

@heath-s heath-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@astyfx
astyfx merged commit 30c18ba into main Sep 18, 2026
6 checks passed
@astyfx
astyfx deleted the fix/subagent-model-effort branch September 18, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants