✨ Keycloak: Configuration to support multiple certificates in Election Event#2570
Open
BelSequent wants to merge 53 commits intomainfrom
Open
✨ Keycloak: Configuration to support multiple certificates in Election Event#2570BelSequent wants to merge 53 commits intomainfrom
BelSequent wants to merge 53 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Keycloak voting-portal theme to conditionally show the certificate (mTLS) login entry point based on a realm-level policy flag, aligning the login UI with election-event certificate configuration.
Changes:
- Gate the certificate login option behind
realm.attributes['voter-digital-cert-policy'] == 'enabled'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 112 out of 114 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
hasura/metadata/databases/backend-db/tables/sequent_backend_certificate_authority.yaml:116
- Hasura permissions for
certificate_authorityare now completely unscoped (check: {}/filter: {}) forca-read,ca-write, andelection-event-cas-tab. This means anyone with these roles can read/insert/delete all certificate authorities across the whole database. If the intent is to restrict CA management to a supertenant/admin context, consider removing theelection-event-cas-tabselect permission here and adding a tighter filter (or moving CA management to a separate table/schema with explicit supertenant-only roles).
insert_permissions:
- comment: ""
permission:
check: {}
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- pem
role: admin-user
- comment: ""
permission:
check: {}
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- pem
- created_at
role: service-account
select_permissions:
- comment: ""
permission:
allow_aggregations: true
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- pem
- created_at
filter: {}
role: admin-user
- comment: ""
permission:
allow_aggregations: true
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- created_at
- pem
filter: {}
role: ca-read
- comment: ""
permission:
allow_aggregations: true
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- created_at
- pem
filter: {}
role: election-event-cas-tab
- comment: ""
permission:
columns:
- id
- common_name
- subject
- issuer_common_name
- issuer
- not_before
- not_after
- fingerprint_sha256
- serial_number
- pem
- created_at
filter: {}
role: service-account
delete_permissions:
- comment: ""
permission:
filter: {}
role: admin-user
- comment: ""
permission:
filter: {}
role: ca-write
- comment: ""
permission:
filter: {}
role: service-account
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/11110