test(downloader): address CodeQL nits in side-table tests#386
Merged
Conversation
- Call download_side_tables() as a statement instead of binding/asserting its always-None return value (CodeQL: use of a procedure's return value). - Patch _RETRY_BACKOFF_SECONDS via the string target form of monkeypatch.setattr, dropping the `import ... as _entsoe_mod` so the module is no longer imported both with `import` and `from ... import` (CodeQL). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #384 addressing the two CodeQL advisory comments on the new tests:
download_side_tables()as a statement instead of binding/asserting its always-Nonereturn value._RETRY_BACKOFF_SECONDSvia the string-target form ofmonkeypatch.setattr, dropping theimport ... as _entsoe_modso the module is no longer imported both withimportandfrom ... import.Test-only (
test:→ no version bump). Fast suite unaffected.🤖 Generated with Claude Code