Promotion: CodeQL alert fixes, sf2-safe 22.2.0 lock#218
Merged
Conversation
…umer contract) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ort (CodeQL) Resolves both open code-scanning alerts: - Alert 85 (py/redundant-comparison, warning): CodeQL mis-normalizes the inline "pos > 1 - warn_frac" / "pos < warn_frac" ternary in boundary_report and flags the second test as always true. Hoist the threshold into a named variable inside a shared _position_flag() helper, which also deduplicates the identical flag logic in report_boundary_positions and boundary_report. - Alert 84 (py/repeated-import, note): remove the function-level "import logging" in tests/test_multitask.py that shadowed the module-level import. No behavior change; black-format the module. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntract) The lecture qmd now passes include_football_match_window to ConfigEntsoe (sf2-safe 22.2.0 event windows), which the team4 consumer-contract gate correctly flagged against the 22.1.0 lock. Bump the lock (pin >=22,<23 already allows it) and sync the lockfile self-version to 8.1.0. Add the two new provider flags (include_football_match_window, include_energy_saving_window) to the exog-provider re-export test and assert registry membership as a superset so additive provider releases in sf2-safe no longer break sf2's suite; removals still fail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…deql-alerts refactor(model_selection): resolve open CodeQL alerts; lock sf2-safe 22.2.0
## [8.1.1-rc.1](v8.1.0...v8.1.1-rc.1) (2026-06-12) ### Code Refactoring * **model_selection:** extract _position_flag, drop shadowing import (CodeQL) ([5f5d096](5f5d096))
Collaborator
Author
|
🎉 This PR is included in version 8.1.1-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
Author
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes develop → main to close the two open code-scanning alerts (filed against main) and sync the dependency lock:
_position_flag()helper inboundary.py— resolves CodeQL alert chore: sync main into develop [skip ci] #85 (py/redundant-comparisonfalse positive on the inline ternary) and deduplicates the flag logic; alert chore(deps): bump spotforecast2-safe floor to >=6.0.0,<7.0 #84 (py/repeated-importintests/test_multitask.py) also fixedrefactormaps to a patch release in.releaserc.json, so this promotion cuts 8.1.1 on main (rc8.1.1-rc.1on develop first).Verified locally on the merged state: 1257 tests green, ruff clean, full quarto render green, REUSE compliant.
🤖 Generated with Claude Code