feat(tasks)!: remove unused demo and n-to-1 task modules and console scripts#220
Merged
Merged
Conversation
Pre-existing import-sort drift flagged by isort 8; no functional change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…scripts A usage scan across all downstream consumers (spotforecast2_abschluss, bart26k-lecture) found no references to the demo and N-to-1 task modules. tasks/task_entsoe.py stays: bart26k-lecture imports entsoe_data_loader / entsoe_test_data_loader, including in the protected 14_team_4_submission.qmd guarded by tests/test_consumer_contract_team4.py. Removed modules: tasks/task_demo.py, tasks/task_n_to_1.py, tasks/task_n_to_1_dataframe.py, tasks/task_n_to_1_with_covariates.py, tasks/task_n_to_1_with_covariates_and_dataframe.py, their tests (test_tasks_smoke.py, test_task_demo_integration.py), the tasks overview docs page, and their quartodoc/sidebar entries. BREAKING CHANGE: the spotforecast-demo, spotforecast-n2o1, spotforecast-n2o1-df, spotforecast-n2o1-cov, and spotforecast-n2o1-cov-df console scripts and the spotforecast2.tasks.task_demo / spotforecast2.tasks.task_n_to_1* modules are removed. spotforecast2-entsoe and spotforecast2.tasks.task_entsoe are unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
🎉 This PR is included in version 9.0.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
Author
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage scan across all downstream consumers (
thk-ai-improvt-ii/spotforecast2_abschluss,bart26k-lecture) found no references to the demo and N-to-1 task modules or their console scripts. They are removed here (−1,850 lines).Kept:
tasks/task_entsoe.pyand thespotforecast2-entsoeCLI —bart26k-lectureimportsentsoe_data_loader/entsoe_test_data_loaderin 8 files, including the protected14_team_4_submission.qmdguarded bytests/test_consumer_contract_team4.py(decider requirement).Changes
tasks/task_demo.pyand the fourtasks/task_n_to_1*.pymodulespyproject.toml: drop the 5 console scripts (spotforecast-demo,spotforecast-n2o1,-df,-cov,-cov-df); keepspotforecast2-entsoetests/test_tasks_smoke.py,tests/test_task_demo_integration.py(covered only removed modules / safe-package code)_quarto.ymlsidebar + quartodoc sections totask_entsoe; deletedocs/tasks/tasks.qmd(ENTSO-E CLI remains documented indocs/tasks/entsoe.qmd); fix dead link; updateMODEL_CARD.mdstyle:commit fixes pre-existing isort drift inmultitask/base.pyBreaking change
Removes the 5 console scripts and the
spotforecast2.tasks.task_demo/task_n_to_1*modules → next promotion majors to 9.0.0. Consumers unaffected: lecture pins<9, abschluss uses no tasks symbols.Verification
uv run pytest tests/ -q— 1247 passed (incl. team4 consumer-contract gate)reuse lint— greenquartodoc_build.py+quartodoc interlinks+quarto render --no-cache— full render green, no dead linksspotforecast2-entsoe --helpworks; removed scripts gone from the venv🤖 Generated with Claude Code