Update str_contains in isJson function#5
Open
nick2687 wants to merge 1 commit intosergant210:masterfrom
Open
Conversation
The second param of str_contains only supports strings, not arrays. This causes a fatal 500 error when used with Modx 3.0. Updated so that the values checked are both strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second param of
str_containsonly supports strings, not arrays.I noticed this caused a fatal 500 error when used with Modx 3.0.
This change updates it so that the values checked are both strings.
*Edit: Apologies @sergant210, I forgot to tag you.