feat: overlay opacity, tap-outside flag, inline snap points and footer presentation - #6
Merged
Merged
Conversation
added 11 commits
September 16, 2026 11:21
…ributed
The crashes worth chasing name nothing of ours on Android: "addViewAt: failed to
insert view [child] into parent [parent] at index N", caused by
"IndexOutOfBoundsException: index=N count=0", with a stack made only of React
Native and framework frames. On iOS the symbols are ours
(HostFittedSheet.setFittedSheetParams, dismissSheet inside
RCTMountingManager.performTransaction) but the state that led there is not.
So the library says it itself. SheetTreeLog records every place where a view
React Native believes it owns is moved by us, naming views the way the crash
report names them - by the React tag on Android, by tag and address on iOS:
host.addView the previous child is dropped without React Native hearing
host.removeView / host.removeViewAt
sheet.addView an overlay child never reaches mHostView, yet
getChildCount goes on counting it
sheet.removeView / sheet.removeViewAt
sheet.detachHost the host leaves the dialog container on dismiss
inline.attachOverlay / dialog.attachOverlay
the overlay is re-parented out of whatever parent React
Native gave it
sheet.insertReactSubview / sheet.removeReactSubview / sheet.attachOverlay /
sheet.destroy the same on iOS
host.mountChild / host.unmountChild / host.prepareForRecycle
what the mounting layer asked for, and where the
HostFittedSheet is thrown away and rebuilt
Entries go to logcat under Sheet2Tree and to the unified log under com.sheet2,
to a 32-entry ring, and on Android to JS as a "sheet2:tree" event.
addSheetTreeListener turns them into app breadcrumbs - which is what survives
into a native crash report - and getSheetTreeLog() reads the ring, the only
channel iOS has for now.
Nothing changes in behaviour: the same views are moved the same way. The two
leftover println("😀 ...") debug lines go with it.
…nput is dismissed
…ter presentation; own touches outside RN surfaces
… sheet with its view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New sheet params to replace @gorhom/bottom-sheet in the MuseScore app:
dismissOnOverlayTap— tap on the background dismisses the sheet independently of swipe (defaults todismissable).overlayOpacity— background dim;0withuseInlinePresentationremoves it and passes touches outside the card to the screen behind.collapsedHeight— lower snap point for inline sheets; the sheet opens there and drags up to its full height.presentationStyle: 'footer'— inline host pinned to the bottom of the screen above inline sheets (buy buttons, full-screen overlays).Fixes found while migrating:
Also includes #5.
Version 7.12.0.