Skip to content

Update README.md - #8

Merged
galetahub merged 5 commits into
serpapi:masterfrom
contributor860:patch-1
Sep 3, 2026
Merged

Update README.md#8
galetahub merged 5 commits into
serpapi:masterfrom
contributor860:patch-1

Conversation

@contributor860

Copy link
Copy Markdown
Contributor

Corrected grammatical and spelling errors

@galetahub galetahub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @contributor860!

Could you also apply the same changes to the README.md.erb?

@contributor860

contributor860 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the fixes, @contributor860!

Could you also apply the same changes to the README.md.erb?

@galetahub I have made the corrections in the 'README.md.erb' also

@contributor860

Copy link
Copy Markdown
Contributor Author

@galetahub, could you please review my changes in both README.md and README.md.erb

@contributor860

Copy link
Copy Markdown
Contributor Author

I know you have a busy schedule, but I just wanted to give a reminder

@galetahub

Copy link
Copy Markdown
Contributor

@contributor860, thanks for the reminder!
I'm not seeing the changes to README.md.erb on my end. Could you please check whether they were pushed?

@contributor860

Copy link
Copy Markdown
Contributor Author

Yes, I have pushed the changes, and it is also showing in the pull requests section.
Screenshot 2026-08-27 174508
Screenshot 2026-08-27 174530

@galetahub

Copy link
Copy Markdown
Contributor

Thanks, @contributor860 - now I see what happened.
You created another PR, while I was looking at this one. Could we make these changes in this PR instead?
README.md is generated from README.md.erb.

@contributor860

Copy link
Copy Markdown
Contributor Author

@galetahub, I have made the changes in the README. md. erb and committed them in this PR as well

@contributor860

Copy link
Copy Markdown
Contributor Author

Also, should I delete the other PR

@contributor860

Copy link
Copy Markdown
Contributor Author

@galetahub Will there be changes made to this README file, like the overall structure?

@contributor860

Copy link
Copy Markdown
Contributor Author

@galetahub Could you please review the changes and merge them? Actually, I am currently creating PRs for README fixes to gain momentum in contributing to this project, and I am using SerpApi to build a project, and during the building of that project if I found any errors or get an idea for a feature then I will update with that

@galetahub

Copy link
Copy Markdown
Contributor

@contributor860 Thank you for pointing it out.
Could you please regenerate README.md by running make readme so that README.md stays in sync with README.md.erb?

@contributor860

Copy link
Copy Markdown
Contributor Author

I have regenerated README.md

@galetahub galetahub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @contributor860! 👍

Only one comment from my side.

Comment thread README.md Outdated
Comment thread README.md.erb Outdated
contributor860 and others added 2 commits September 2, 2026 19:21
Co-authored-by: Igor Galeta <galeta.igor@gmail.com>
Co-authored-by: Igor Galeta <galeta.igor@gmail.com>
@contributor860

Copy link
Copy Markdown
Contributor Author

I have made the required changes

@galetahub galetahub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @contributor860, LGTM 👍

@galetahub
galetahub merged commit 931260e into serpapi:master Sep 3, 2026
10 checks passed
@contributor860

Copy link
Copy Markdown
Contributor Author

Thanks for merging my PR, and sorry if I bothered you during the conversations. As I am building a project using SerpApi, if I encounter any issues or discover a new feature idea, I will create an issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants