feat: add sub worflows run on FuncDSL #1295#1299
Draft
matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
Draft
feat: add sub worflows run on FuncDSL #1295#1299matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
matheusandre1 wants to merge 1 commit intoserverlessworkflow:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for running nested/sub workflows (“run workflow” tasks) from the Func fluent DSL, closing #1295.
Changes:
- Extend Func FuncDo fluent interfaces/builders to include
WorkflowFluentso workflow tasks can be added from Func DSL chains - Add
FuncDSL.workflow(WorkflowConfigurer)helper to append workflow subflow tasks - Add a JUnit test validating the generated
RunWorkflowstructure andawait(false)propagation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| experimental/fluent/func/src/test/java/io/serverlessworkflow/fluent/func/FuncDSLTest.java | Adds a test covering building a workflow task via Func DSL and verifying the produced RunWorkflow fields. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/spi/FuncDoFluent.java | Extends Func DSL fluent surface to include workflow tasks (WorkflowFluent). |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java | Introduces FuncDSL.workflow(WorkflowConfigurer) task configurer entrypoint. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncTaskItemListBuilder.java | Implements workflow task addition for Func task lists by delegating to spec TaskItemListBuilder. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncDoTaskBuilder.java | Wires workflow(...) into the Func do task builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fjtirado
reviewed
Apr 14, 2026
Collaborator
fjtirado
left a comment
fjtirado
left a comment
There was a problem hiding this comment.
I think this needs some reworking
Collaborator
|
@matheusandre1 I fixed a problem with the subflow input, which is optiona and was throwing a null pointer |
matheusandre1
force-pushed
the
feat-1295
branch
from
a4cfabb to
7f053c4
Compare
Signed-off-by: Matheus Andre <matheusandr2@gmail.com>
matheusandre1
force-pushed
the
feat-1295
branch
from
7f053c4 to
8fd32b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: Closes: #1295
Special notes for reviewers:
Additional information (if needed):