Repository navigation
feat(board): claim limits, similar-issue details, admin toolbar with prompt comments, issues as Markdown (T-10) - #22
Merged
Conversation
…prompt comments, issues as Markdown (T-10) - Claims: at most 3 at a time; 3 expired claims or 2 issues removed by a moderator block claiming for 2 weeks (computed from the record, so restoring an issue lifts its block). BoardMe tells the client; the task page disables Claim and shows why (specs/16 §8.4). - Report dialog: similar issues are open or planned only; a title opens the issue's details in a popup with Close and Vote instead. - Done lists finished bugs and improvements only, no tasks. - Issue page: admins get a toolbar with the common actions and ⋮ on one row; buttons that don't fit move into ⋮ (ToolbarOverflowLayout). Visible comments get checkboxes; Select for building leaves the unchecked ones out of the task prompt (BoardTask.promptExcludedCommentIds). Creating a task from several issues lists their comments in the task dialog (ChecklistFieldSpec). - /improvements/p/<n>.md serves the issue as Markdown; task prompts link the issues there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wonky task review: T-10: Improvements to contribution systemScreenshot: the description has an image of the changed UI. This PR properly delivers the expected features for T-10, adding UI popups and filters to board workflows, limiting task claims dynamically, and granting control over comment context in task prompts. Testing coverage is thorough and directly addresses the requirements. An additional layout refactor for the admin actions menu was implemented smoothly alongside the task creation upgrades.
Scope:
Tests: Added. Server and widget tests successfully cover all new conditions, including blocks, prompts, MD routes, and widget popups. Specs: Updated. The specs file was correctly updated. Risks:
Facts
Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wonky-Task: T-10
Wonky-Claim: 9MXR-5MFP
Improvements to the contribution system (#10, #14, #15, #20): claim limits and blocks, similar-issue details while reporting, a Done tab without tasks, choosing the comments a task prompt is written from, and every issue as Markdown. Spec 16 is updated (§4.2.2, §4.3, §4.4, §4.5, §6.4, §8.1, new §8.4, §9.3, §10.1, §11, §12, §14).
Acceptance criteria
maxActiveClaimsPerUseris 3;claimTaskanswerslimitExceededfor a 4th.BoardMe.maxActiveClaimstells the client.expiredactivity row. Every 3 of them block claiming for 14 days from the last one (BoardTaskClaims.claimBlock, configexpiredClaimsToBlock,claimBlockDays).claimTaskanswersforbiddenwith the reason.BoardMe.claimBlockedUntil/claimBlockedReasondrive the task page: Claim this task is disabled and a notice says until when and why.moderation: removed); declined issues are valid reports. Two removals block claiming for 14 days (invalidPostsToBlock). The block is computed from the record, not stored, so restoring a removed issue (undo) lifts it. Admins are exempt.board.similarreturnsopen/plannedissues only (the triage's duplicate check still seesdone). The client also drops done and shipped issues, for older servers.#412 Titleis a link (hover underline, focus ring, Enter/Space, screen-reader label). It opensdialog.board.similarPostover the report dialog: chips, status, votes, author and the Markdown body, with Close and Vote instead.excludedComments. Creating a task from several issues on the board lists their comments in the task dialog (ChecklistFieldSpec, MCP-operable). The issue page also gets an admin toolbar with the common actions and ⋮ on one row; buttons that don't fit move into ⋮, least important first (ToolbarOverflowLayout, as in the editors).BoardTask.promptExcludedCommentIds, migration20261019202955634-board-claim-limits). Every AI pass (first prompt, Regenerate, rewrites after issue changes, merged tasks) leaves them out./improvements/p/<n>.md(text/markdown,no-cache) gives the title, the facts, the body, the included details and the visible comments. Public content only; anything not public answers 404 (BoardMarkdown,ImprovementsRedirectRoute)..md. Reports this task comes from linkshttps://wonky.work/improvements/p/<n>.md.Screenshots
Issue page for an admin: the toolbar with ⋮ on one row, and the comment checkboxes (one unchecked)
A narrow window: Merge into… and Decline… moved into ⋮
Similar issues in the report dialog, and the details popup
A claim-blocked user on a task page
Done tab: issues only
Tests
board_claim_limits_test(limit of 3, 3 expiries, 2 removals, restore lifts the block, the block ends after 14 days),board_task_context_test(only selected comments reach the prompt, also after a merge; foreign comment uuids are refused;.mdlinks in the prompt; the Markdown content; held and missing issues have none),improvements_redirect_route_test(.md→ 200text/markdown, 404),task_prompt_template_test. Full suite: 2287 passed.wonky_app: report dialog (done/shipped not suggested, popup in light and dark, Vote instead from the popup), Done tab without tasks (light and dark), issue page (toolbar and ⋮ on one row, overflow on a narrow window, comment checkboxes, the unchecked comment left out, no checkboxes when not buildable or not an admin), the board's task dialog checklist,createTaskwithexcludedCommentsthrough undo/redo, trail parsing.flutter test -x golden,slow,e2e: 907 passed.The screenshots live in their own commit (
ee2f1c25) and are removed in the next one, so the squash merge adds no images.🤖 Generated with Claude Code