Use "github.com/pkg/term" instead of "github.com/kless/term"#1
Open
markelog wants to merge 1 commit intosethgrid:masterfrom
Open
Use "github.com/pkg/term" instead of "github.com/kless/term"#1markelog wants to merge 1 commit intosethgrid:masterfrom
markelog wants to merge 1 commit intosethgrid:masterfrom
Conversation
markelog
added a commit
to markelog/list
that referenced
this pull request
Sep 6, 2016
Owner
|
@markelog thanks for the pull request. I have been on vacation. The changes seem legit. I'll try to verify things today and hopefully merge today too. Thanks! |
| c.Position.X, c.StartingPosition.X = col, col | ||
| c.Position.Y, c.StartingPosition.Y = line, line | ||
| c.terminal, err = term.New() | ||
| c.terminal, err = term.Open("/bin/stty") |
Owner
There was a problem hiding this comment.
I have an older Go program that I resurrected that uses curse and it gets an error here:
open /bin/stty: operation not permitted
I've tried it as root too just to be sure.
Author
There was a problem hiding this comment.
Hm, weird, I can take a look after the weekend, if you not figure this out by then that is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems kless version is not maintained anymore -
github.com/kless/term/issuesWhereas
github.com/pkg/termone has support and more "credibility", plus it seems fallbacks are no longer needed?