add point source with far-field directivity of circular piston#156
Open
fietew wants to merge 7 commits intosfstoolbox:masterfrom
Open
add point source with far-field directivity of circular piston#156fietew wants to merge 7 commits intosfstoolbox:masterfrom
fietew wants to merge 7 commits intosfstoolbox:masterfrom
Conversation
Member
|
The machine is complaining: And https://travis-ci.org/sfstoolbox/sfs-python/jobs/615577318 contains: Note that the line number is meant within the docstring. |
mgeier
reviewed
Dec 17, 2019
mgeier
reviewed
Dec 19, 2019
mgeier
reviewed
Jan 7, 2020
| G(\x-\x_0,\w) = \frac{1}{2\pi} | ||
| \frac{J_1(\wc R \sin(\Theta))}{\wc R \sin(\Theta)} | ||
| \frac{\e{-\i\wc|\x-\x_0|}}{|\x-\x_0|} | ||
| with :math:`\Theta` more conveniently defined by its cosine |
Member
There was a problem hiding this comment.
sfs/fd/source.py:docstring of sfs.fd.source.point_circular_piston:20: WARNING: Explicit markup ends without a blank line; unexpected unindent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new source type with far-field directivity of circular piston radiator