Merged
Conversation
Member
Author
|
the examples are now here: |
mgeier
reviewed
Aug 30, 2025
fs446
force-pushed
the
add_wfs_point_25d_fd_examples
branch
from
5394090 to
4cdbb56
Compare
mgeier
reviewed
Sep 2, 2025
fs446
force-pushed
the
add_wfs_point_25d_fd_examples
branch
from
eae2b27 to
64e027b
Compare
mgeier
reviewed
Sep 11, 2025
mgeier
reviewed
Sep 15, 2025
Member
Author
|
mgeier, thanks for the comments and suggestions, I added this and some more in 7d4f267 and commented directly via the commit message. |
fs446
force-pushed
the
add_wfs_point_25d_fd_examples
branch
from
c24cd6c to
71415ba
Compare
… will be adapted in near future
mgeier
reviewed
Sep 23, 2025
doc/examples/wfs-referencing.ipynb
Outdated
| "xref = [0, 0.1175, 0] # intentionally no stationary phase point\n", | ||
| "# we don't forget to normalize the point source's amplitude\n", | ||
| "# to this new reference point:\n", | ||
| "normalize_gain = 4 * np.pi * np.linalg.norm(xs - np.array(xref))\n", |
Member
There was a problem hiding this comment.
Suggested change
| "normalize_gain = 4 * np.pi * np.linalg.norm(xs - np.array(xref))\n", | |
| "normalize_gain = 4 * np.pi * np.linalg.norm(xs - xref)\n", |
doc/examples/wfs-referencing.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "xref = [0, 0.1175, 0] # intentionally no stationary phase point\n", |
Member
There was a problem hiding this comment.
This is of course a matter of taste, but I prefer it without brackets:
Suggested change
| "xref = [0, 0.1175, 0] # intentionally no stationary phase point\n", | |
| "xref = 0, 0.1175, 0 # intentionally no stationary phase point\n", |
as proposed by mgeier
mgeier suggested to improve np.array([[0, 0, 0]]*array.x.shape[0]) and np.array([xref]*array.x.shape[0]) by a handling in sound_field()
…legant as proposed by mgeier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.