perf: setup-chromeのinstall-dependenciesを無効化 - #10
Merged
Conversation
apt-get updateだけで約7秒かかっており、依存ライブラリは全てGitHub-hosted ubuntu-latestに標準で入っている(already the newest version)ことをログで 確認済み。chromagic-demoでブランチ直接参照して実際にstorycapが動くか 検証してからマージする。
|
🎉 This PR is included in version 1.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
「速さで戦う」施策の続き。前回のキャッシュ化後もSetup Chrome for Testingステップが7.7秒かかっており、詳細ログを見るとChrome自体はキャッシュヒットしているのに
install-dependencies: trueが毎回apt-get updateを走らせているのが原因と判明(パッケージリスト取得だけで約7秒)。インストール対象の依存ライブラリ(libnss3, libatk等)はログ上すべて
already the newest version— GitHub-hosted ubuntu-latestランナーに標準で揃っており、このapt処理自体が実質不要だった。変更内容
install-dependencies: true→false実機検証(chromagic-demoでブランチ直接参照)
Setup Chrome for Testing: 7.7秒 → 0.35秒Screenshot was ended successfully)、エラーなし累計の効果(未キャッシュ状態との比較)
初回比で約60%以上の短縮。
リスク
GitHub-hosted ubuntu-latestランナーの将来のイメージ更新で依存ライブラリが欠ける可能性はゼロではないが、現状はプリインストール済み。壊れた場合はこのコミットをrevertすれば元に戻せる。
動作確認
🤖 Generated with Claude Code