Skip to content

Conversation

@aidanfnv
Copy link
Contributor

@aidanfnv aidanfnv commented Dec 3, 2025

This changes the .so file regex patterns in linkcheck_ignore to encompass all .so paths, instead of specific .so paths.

The Slang .so libraries have been renamed, so the current regex patterns do not ignore the bad links made from references to them in the docs. Sphinx misinterprets .so filenames as website URLs with the Somalian .so country TLD, which inevitably fail the link check, so those fake links need to be ignored.

@aidanfnv aidanfnv changed the title Ignore .so files in linkcheck Ignore all .so files in linkcheck Dec 3, 2025
@aidanfnv aidanfnv marked this pull request as ready for review December 3, 2025 18:02
@aidanfnv aidanfnv requested a review from jkwak-work December 3, 2025 18:03
Copy link
Contributor

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/conf.py Outdated
r"http://libllvm\.so.*",
r"http://libLLVM\.so.*",
r"http://slang\.so.*",
r"http://[^ ]+\.so.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may meant to use

r"http://[^\.]+\.so.*",

@aidanfnv aidanfnv merged commit c3b308e into shader-slang:main Dec 3, 2025
2 checks passed
@aidanfnv aidanfnv deleted the fix/so-linkcheck branch December 3, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants