Fix profile JSON import broken by trailing newline#3244
Open
trulyliu wants to merge 1 commit into
Open
Conversation
The gson→org.json migration in df4d65c wrapped the root-value read in `while (JSONTokener.more()) process(nextValue())`, but JSONTokener.more() reports true on trailing whitespace. Every JSON file ending with a newline (i.e. essentially every file) hits a second nextValue() call that runs off the end and throws JSONException, before finalize() persists the parsed profile. Restore the pre-migration single-value semantic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
This PR fixes a bug in the latest version that prevents the import of JSON configuration files on TV. |
Mygod
requested changes
May 10, 2026
Mygod
left a comment
Mygod
left a comment
Contributor
There was a problem hiding this comment.
This changes the functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gson→org.json migration in df4d65c wrapped the root-value read in
while (JSONTokener.more()) process(nextValue()), but JSONTokener.more() reports true on trailing whitespace. Every JSON file ending with a newline (i.e. essentially every file) hits a second nextValue() call that runs off the end and throws JSONException, before finalize() persists the parsed profile.Restore the pre-migration single-value semantic.